-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: iam policy about registering/deregistering targets #1618
fix: iam policy about registering/deregistering targets #1618
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @1newsr! |
8c42abc
to
bcd4a11
Compare
bcd4a11
to
699e56c
Compare
check cla signature. |
/assign @M00nF1sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I think this is a gap in our provided policy. thanks for fixing this.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 1newsr, M00nF1sh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
If you specify a target group created outside the AWS Load Balancer Controller for TargetGroupBinding, the following error occurs.
The reason for this is that target groups created outside the AWS Load Balancer Controller do not have the specified tags assigned by the controller and do not match the condition of iam policy.
About
RegisterTargets
andDeregisterTargets
, the conditions have been modified to be relaxed.