Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: iam policy about registering/deregistering targets #1618

Merged

Conversation

1newsr
Copy link
Contributor

@1newsr 1newsr commented Nov 4, 2020

If you specify a target group created outside the AWS Load Balancer Controller for TargetGroupBinding, the following error occurs.

{"level":"info","ts":1604527749.9575977,"msg":"registering targets","arn":"arn:aws:elasticloadbalancing:us-west-2:XXXXXXXXXX:targetgroup/app-20201104085105927100000001/161ecbe439f88334","targets":[{"AvailabilityZone":null,"Id":"10.1.67.253","Port":80}]}
{"level":"error","ts":1604527749.9936082,"logger":"controller","msg":"Reconciler error","reconcilerGroup":"elbv2.k8s.aws","reconcilerKind":"TargetGroupBinding","controller":"targetGroupBinding","name":"httpbin","namespace":"default","error":"AccessDenied: User: arn:aws:sts::XXXXXXXXXX:assumed-role/aws-lb-controller/1604526445790853017 is not authorized to perform: elasticloadbalancing:RegisterTargets on resource: arn:aws:elasticloadbalancing:us-west-2:XXXXXXXXXX:targetgroup/app-20201104085105927100000001/161ecbe439f88334\n\tstatus code: 403, request id: 75cf841f-bde3-43b6-b84e-22b103b0a121"}

The reason for this is that target groups created outside the AWS Load Balancer Controller do not have the specified tags assigned by the controller and do not match the condition of iam policy.

About RegisterTargets and DeregisterTargets, the conditions have been modified to be relaxed.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 4, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @1newsr!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 4, 2020
@1newsr 1newsr force-pushed the fix/iam-policy-about-targetgroup branch from 8c42abc to bcd4a11 Compare November 4, 2020 22:32
@1newsr 1newsr force-pushed the fix/iam-policy-about-targetgroup branch from bcd4a11 to 699e56c Compare November 4, 2020 22:42
@1newsr
Copy link
Contributor Author

1newsr commented Nov 4, 2020

check cla signature.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 4, 2020
@1newsr
Copy link
Contributor Author

1newsr commented Nov 4, 2020

/assign @M00nF1sh

Copy link
Collaborator

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
I think this is a gap in our provided policy. thanks for fixing this.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 1newsr, M00nF1sh
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@M00nF1sh M00nF1sh merged commit 3265d5c into kubernetes-sigs:main Nov 5, 2020
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants