Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

abstract retry_utils and add retry for listener certificate attachment #1631

Merged
merged 1 commit into from
Nov 10, 2020
Merged

abstract retry_utils and add retry for listener certificate attachment #1631

merged 1 commit into from
Nov 10, 2020

Conversation

M00nF1sh
Copy link
Collaborator

@M00nF1sh M00nF1sh commented Nov 10, 2020 •
edited

description

  1. abstract retry_urils.RetryImmediateOnError functionality. It should be preferred over wait.PollImmediate when the intention is to retry an action. (otherwise, wait.PollImmediate should be preferred when wait for a condition)
  2. add retry for ListenerNotFound error when attach certificate to newly created listener.

test done

  1. unit test
  2. e2e test
  3. tested with HTTPS listeners with multiple certificates.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kishorj, M00nF1sh
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@M00nF1sh M00nF1sh merged commit 7b823fb into kubernetes-sigs:main Nov 10, 2020
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
@M00nF1sh @Timothy-Dougherty
abstract retry_utils and add retry for listener certficate attachment (…
28168ff 
…kubernetes-sigs#1631)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kishorj kishorj kishorj approved these changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@M00nF1sh @k8s-ci-robot @kishorj