-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix annotation documentation about ALB attributes #1722
Conversation
Welcome @giannisbetas! |
Hi @giannisbetas. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Codecov Report
@@ Coverage Diff @@
## main #1722 +/- ##
=======================================
Coverage 46.72% 46.72%
=======================================
Files 110 110
Lines 5984 5984
=======================================
Hits 2796 2796
Misses 2923 2923
Partials 265 265 Continue to review full report at Codecov.
|
/retest |
@giannisbetas: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @M00nF1sh |
thanks for making this change. just FYI, we'll add a new crd as IngressClass's parameter, where we can force customers using IngressGroup to set LB attributes there instead of on individual Ingresses in the future. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: giannisbetas, M00nF1sh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The documentation mentions that the
MergeBehavior
for the load-balancer-attributes annotation isMerge
.However, if the same attributes are defined across the ingresses of the same ingressGroup, they need to have the same values in order to be merged.