Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the regression of IP mode support for fargate pods #2158

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

M00nF1sh
Copy link
Collaborator

@M00nF1sh M00nF1sh commented Aug 4, 2021

Issue

#2156

Description

Fix the regression of IP mode support for Fargate pods introduced by #2137.
These Fargate pod's ENI have to be resolved via VPC IPAddress.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 4, 2021
@M00nF1sh M00nF1sh changed the title fix the regression of IP mode support for fargate pods [WIP]fix the regression of IP mode support for fargate pods Aug 4, 2021
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 4, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2021
@M00nF1sh M00nF1sh force-pushed the fix_fargate branch 2 times, most recently from 5b19940 to 7c2c2ef Compare August 4, 2021 04:22
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 4, 2021
@M00nF1sh M00nF1sh changed the title [WIP]fix the regression of IP mode support for fargate pods Fix the regression of IP mode support for fargate pods Aug 4, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 4, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #2158 (75f4bd0) into main (07089ba) will increase coverage by 0.21%.
The diff coverage is 93.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2158      +/-   ##
==========================================
+ Coverage   52.04%   52.26%   +0.21%     
==========================================
  Files         132      132              
  Lines        7130     7166      +36     
==========================================
+ Hits         3711     3745      +34     
- Misses       3131     3132       +1     
- Partials      288      289       +1     
Impacted Files Coverage Δ
pkg/targetgroupbinding/resource_manager.go 18.41% <0.00%> (ø)
pkg/networking/pod_eni_info_resolver.go 94.11% <95.12%> (-0.06%) ⬇️
pkg/k8s/node_utils.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07089ba...75f4bd0. Read the comment docs.

@M00nF1sh
Copy link
Collaborator Author

M00nF1sh commented Aug 4, 2021

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishorj, M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kishorj
Copy link
Collaborator

kishorj commented Aug 4, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2021
@M00nF1sh
Copy link
Collaborator Author

M00nF1sh commented Aug 4, 2021

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2021
@M00nF1sh M00nF1sh merged commit 9b3880f into kubernetes-sigs:main Aug 4, 2021
M00nF1sh added a commit to M00nF1sh/aws-load-balancer-controller that referenced this pull request Aug 4, 2021
k8s-ci-robot added a commit that referenced this pull request Aug 4, 2021
cherry-pick into release-2.2: fix the regression of IP mode support for fargate pods (#2158)
amorey pushed a commit to muicss/aws-load-balancer-controller that referenced this pull request Feb 1, 2022
alebedev87 pushed a commit to alebedev87/aws-load-balancer-controller that referenced this pull request Oct 26, 2023
alebedev87 pushed a commit to alebedev87/aws-load-balancer-controller that referenced this pull request Oct 26, 2023
cherry-pick into release-2.2: fix the regression of IP mode support for fargate pods (kubernetes-sigs#2158)
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants