New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort ingress rules by path length and pathType #2409
Sort ingress rules by path length and pathType #2409
Conversation
Hi @oliviassss. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## main #2409 +/- ##
==========================================
+ Coverage 53.83% 53.94% +0.10%
==========================================
Files 144 144
Lines 8167 8195 +28
==========================================
+ Hits 4397 4421 +24
- Misses 3453 3455 +2
- Partials 317 319 +2
Continue to review full report at Codecov.
|
/ok-to-test |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kishorj, oliviassss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
/remove-hold |
@oliviassss Is there any plans to get this merged? |
Lets ensure the following for backwards compatibility:
|
bcf6f6e
to
1fefe3f
Compare
Sort Ingress rules based on the strategy:
|
1fefe3f
to
9c6e750
Compare
9c6e750
to
a61da53
Compare
/retest |
/lgtm |
* sort ingress rules by path length * add unit test * sort paths instead of sorting rules directly * update sorting strategy
Issue
#2203
Description
Sort Ingress rules based on the strategy:
ref: Kubernetes Ingress (https://kubernetes.io/docs/concepts/services-networking/ingress/#multiple-matches).
Tests
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く