New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding optional support for topologySpreadConstraints to helm chart #2575
adding optional support for topologySpreadConstraints to helm chart #2575
Conversation
Hi @stensonb. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## main #2575 +/- ##
=======================================
Coverage 53.85% 53.85%
=======================================
Files 144 144
Lines 8165 8165
=======================================
Hits 4397 4397
Misses 3451 3451
Partials 317 317 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the README.md with the new configuration parameter
/ok-to-test |
/retest |
appears due to recent changes in #2517. I will investigate further. |
please rebase after PR 2577 gets merged |
48ec2d3
to
1994415
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kishorj, stensonb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ubernetes-sigs#2575) * adding support for topologySpreadConstraints * update readme
…ubernetes-sigs#2575) * adding support for topologySpreadConstraints * update readme
Issue
#2563
(replacement for #2571 )
Description
This adds optional (defaulting to empty)
topologySpreadConstraints
to the helm chart.Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯