Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding optional support for topologySpreadConstraints to helm chart #2575

Merged

Conversation

stensonb
Copy link
Contributor

Issue

#2563

(replacement for #2571 )

Description

This adds optional (defaulting to empty) topologySpreadConstraints to the helm chart.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 22, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @stensonb. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 22, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2575 (34d5ffb) into main (f014735) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2575   +/-   ##
=======================================
  Coverage   53.85%   53.85%           
=======================================
  Files         144      144           
  Lines        8165     8165           
=======================================
  Hits         4397     4397           
  Misses       3451     3451           
  Partials      317      317           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f014735...34d5ffb. Read the comment docs.

Copy link
Collaborator

@kishorj kishorj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the README.md with the new configuration parameter

@kishorj kishorj added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 22, 2022
@kishorj
Copy link
Collaborator

kishorj commented Mar 22, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 22, 2022
@BryanStenson-okta
Copy link

/retest

@kishorj
Copy link
Collaborator

kishorj commented Mar 22, 2022

appears due to recent changes in #2517. I will investigate further.

@kishorj
Copy link
Collaborator

kishorj commented Mar 23, 2022

please rebase after PR 2577 gets merged

@stensonb stensonb force-pushed the adding-topology-spread-constraints branch from 48ec2d3 to 1994415 Compare March 23, 2022 03:05
@kishorj
Copy link
Collaborator

kishorj commented Mar 23, 2022

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishorj, stensonb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2022
@k8s-ci-robot k8s-ci-robot merged commit 81e52ac into kubernetes-sigs:main Mar 23, 2022
thejasn pushed a commit to thejasn/aws-load-balancer-controller that referenced this pull request Apr 7, 2022
…ubernetes-sigs#2575)

* adding support for topologySpreadConstraints

* update readme
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
…ubernetes-sigs#2575)

* adding support for topologySpreadConstraints

* update readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants