-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated deployment for prometheus.io annotations when sericeMonitor i… #2606
Conversation
Welcome @tamboliasir1! |
Hi @tamboliasir1. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## main #2606 +/- ##
=======================================
Coverage 53.83% 53.83%
=======================================
Files 144 144
Lines 8167 8167
=======================================
Hits 4397 4397
Misses 3453 3453
Partials 317 317 Continue to review full report at Codecov.
|
@tamboliasir1, thanks for your contribution. |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kishorj, tamboliasir1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Fixes: #2601
Made changes in deployment for #2601
Thank you for this opportunity.