Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Dockerfile go dependency caching #2626

Merged
merged 1 commit into from Jul 15, 2022
Merged

Fix Dockerfile go dependency caching #2626

merged 1 commit into from Jul 15, 2022

Conversation

hintofbasil
Copy link
Contributor

Issue

N/A

Description

The current Dockerfile uses a bind mount when downloading the go dependencies.
This causes the entire project folder to be added to the Docker context when
only the go.mod and go.sum files are needed. This ends up breaking the
caching of the dependencies as any change to any file in the project will cause
the docker context to change. Removing this bind mount allows the dependencies
to be correctly cached.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@hintofbasil
Fix Dockerfile go dependency caching
6c74842 
The current Dockerfile uses a bind mount when downloading the go dependencies.
This causes the entire project folder to be added to the Docker context when
only the `go.mod` and `go.sum` files are needed.  This ends up breaking the
caching of the dependencies as any change to any file in the project will cause
the docker context to change.  Removing this bind mount allows the dependencies
to be correctly cached.
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 25, 2022 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 25, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @hintofbasil!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @hintofbasil. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 25, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 25, 2022
@hintofbasil
Copy link
Contributor Author

/easycla

2 similar comments
@hintofbasil
Copy link
Contributor Author

/easycla

@hintofbasil
Copy link
Contributor Author

/easycla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 25, 2022
@kishorj kishorj added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 29, 2022
@kishorj
Copy link
Collaborator

kishorj commented Apr 29, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 29, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2626 (6c74842) into main (dd57d47) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2626   +/-   ##
=======================================
  Coverage   53.94%   53.94%           
=======================================
  Files         144      144           
  Lines        8197     8197           
=======================================
  Hits         4422     4422           
  Misses       3456     3456           
  Partials      319      319

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd57d47...6c74842. Read the comment docs.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hintofbasil, kishorj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2022
@kishorj
Copy link
Collaborator

kishorj commented Jul 15, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8da0d47 into kubernetes-sigs:main Jul 15, 2022
@kishorj kishorj mentioned this pull request Aug 10, 2022
Merged
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
@hintofbasil @Timothy-Dougherty
Fix Dockerfile go dependency caching (kubernetes-sigs#2626)
51c0dea 
The current Dockerfile uses a bind mount when downloading the go dependencies.
This causes the entire project folder to be added to the Docker context when
only the `go.mod` and `go.sum` files are needed.  This ends up breaking the
caching of the dependencies as any change to any file in the project will cause
the docker context to change.  Removing this bind mount allows the dependencies
to be correctly cached.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kishorj kishorj kishorj approved these changes

@M00nF1sh M00nF1sh Awaiting requested review from M00nF1sh

Assignees

@kishorj kishorj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hintofbasil @k8s-ci-robot @kishorj @codecov-commenter