Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add guide on using a self managed (or existing) load balancer #2765

Merged
merged 4 commits into from Sep 1, 2022
Merged

add guide on using a self managed (or existing) load balancer #2765

merged 4 commits into from Sep 1, 2022

Conversation

geoffcline
Copy link
Contributor

Issue

Description

Some organizations have strict controls around creating new load balancers. Those orgs may prefer the load balancer controller to merely update target groups, instead of owning the load balancer.

This guide introduces users to this concept. We have existing docs around what the TargetGroupBinding CRD is, but this page helps users discover and use this feature.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2022 •
edited

Codecov Report

Base: 54.04% // Head: 54.04% // No change to project coverage 👍

Coverage data is based on head (068c6f2) compared to base (6d3e976).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2765   +/-   ##
=======================================
  Coverage   54.04%   54.04%           
=======================================
  Files         144      144           
  Lines        8223     8223           
=======================================
  Hits         4444     4444           
  Misses       3461     3461           
  Partials      318      318

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kishorj kishorj added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 24, 2022
kishorj
kishorj reviewed Aug 24, 2022
View reviewed changes
docs/guide/use_cases/self_managed_lb/index.md Outdated Show resolved Hide resolved
docs/guide/use_cases/self_managed_lb/index.md Outdated Show resolved Hide resolved
docs/guide/use_cases/self_managed_lb/index.md Outdated

Use the TargetGroupBinding CRD to sync a Kubernetes service with the targets of a load balancer.

First, a load balancer is manually created directly with AWS. A [listener](https://docs.aws.amazon.com/elasticloadbalancing/latest/application/load-balancer-listeners.html) and a [target group](https://docs.aws.amazon.com/elasticloadbalancing/latest/application/load-balancer-target-groups.html) is added to the load balancer.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example below uses NLB. Lets be consistent.

Lets also use active voice for this paragraph.

docs/guide/use_cases/self_managed_lb/index.md Outdated Show resolved Hide resolved
mkdocs.yml Outdated Show resolved Hide resolved
geoffcline
geoffcline commented Aug 30, 2022
View reviewed changes
Copy link
Contributor Author

@geoffcline geoffcline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revise

@geoffcline
Copy link
Contributor Author

Thanks for your feedback @kishorj

I fixed everything, but I did leave some passive voice. I am describing what will happen later in the guide.

@kishorj
Copy link
Collaborator

kishorj commented Aug 31, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geoffcline, kishorj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2022
@k8s-ci-robot k8s-ci-robot merged commit bb856b6 into kubernetes-sigs:main Sep 1, 2022
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
@geoffcline @Timothy-Dougherty
add guide on using a self managed (or existing) load balancer (kubern…
9d74af6 
…etes-sigs#2765)

* init draft

* fixup and test

* revise

* revise
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kishorj kishorj kishorj left review comments

@M00nF1sh M00nF1sh Awaiting requested review from M00nF1sh

Assignees

@kishorj kishorj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@geoffcline @codecov-commenter @kishorj @k8s-ci-robot