Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in test script #3226

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

oliviassss
Copy link
Collaborator

Issue

Description

Fix typo in script/run-e2e-test.sh

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 6, 2023
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (b2f4074) 54.70% compared to head (4ee739e) 54.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3226   +/-   ##
=======================================
  Coverage   54.70%   54.70%           
=======================================
  Files         148      148           
  Lines        8590     8590           
=======================================
  Hits         4699     4699           
  Misses       3559     3559           
  Partials      332      332           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kishorj kishorj added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 6, 2023
@kishorj
Copy link
Collaborator

kishorj commented Jun 6, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishorj, oliviassss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1ea04c7 into kubernetes-sigs:main Jun 6, 2023
2 checks passed
rdrgmnzs pushed a commit to rdrgmnzs/aws-load-balancer-controller that referenced this pull request Jun 8, 2023
k8s-ci-robot pushed a commit that referenced this pull request Jun 9, 2023
…licy/v1 (#3230)

* fix typo in test script (#3226)

* Remove policy/v1beta1 since the min supported k8s version supports policy/v1

---------

Co-authored-by: Olivia Song <sonyingy@amazon.com>
@oliviassss oliviassss deleted the refactor-e2e-script branch July 5, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants