Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't block TGB reconciliation loop on failed SG ingress reconciliation #3296

Merged
merged 4 commits into from
Aug 30, 2023
Merged

don't block TGB reconciliation loop on failed SG ingress reconciliation #3296

merged 4 commits into from
Aug 30, 2023

Commits on Jul 26, 2023

  1. don't block TGB reconciliation loop on failed SG ingress reconciliation 

    the controller performs an SG reconciliation step for all (cluster-wide) SGs gathered from all TGBs during the TGB reconciliation loop, before TG endpoints are reconciled: https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/d177c898ddd86071eecc2fd918d72ebfb0af7892/pkg/targetgroupbinding/resource_manager.go#L139-L141

the way the code is currently written, this means that any failure during SG reconciliation blocks reconciliation of all targets across the whole cluster. such a failure can be caused by something as innocuous as a SG being deleted before the associated TGB is deleted, or a SG being entered on a TGB erroneously. this can easily lead to severe outages if not remediated quickly.

this commit changes the method `reconcileWithIngressPermissionsPerSG` to not exit on a single failed SG ingress reconciliation - instead it will log the offending error and continue through the loop.
    @michaelsaah
    michaelsaah committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    5e8c6df View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. group errors, emit one event per reconcile, requeue on failure

    @michaelsaah
    michaelsaah committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    d6e8667 View commit details
    Browse the repository at this point in the history

  2. whitespace

    @michaelsaah
    michaelsaah committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    6b78ca3 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. slice init style suggestion 

    Co-authored-by: John Gardiner Myers <jgmyers@proofpoint.com>
    @michaelsaah @johngmyers
    michaelsaah and johngmyers committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    4607bb4 View commit details
    Browse the repository at this point in the history