Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add johngmyers as approver #3356

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Conversation

johngmyers
Copy link
Contributor

Issue

N/A

Description

Promotes johngmyers to approver

Requirements:

  • Reviewer of the codebase for at least 3 months
  • Primary reviewer for at least 10 substantial PRs to the codebase

#2950, #2942, #2425, #2963, #2988,
#2986, #3269, #3147, #2735, #3312,
#3332, #3343, #3347,

  • Reviewed or merged at least 30 PRs to the codebase

#2950, #2942, #2880, #2866, #2453,
#2435, #2433, #2425, #2442, #2500,
#2443, #2963, #2735, #2881, #2840,
#2987, #2988, #2992, #2993, #2955,
#2990, #2945, #3007, #3025, #3269,
#3147, #3292, #3272, #3318, #3332,
#3343, #3347,

  • Nominated by a subproject owner
    • With no objections from other subproject owners
    • Done through PR to update the top-level OWNERS file

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 23, 2023
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (aa893b5) 55.61% compared to head (2e9ce0f) 55.61%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3356   +/-   ##
=======================================
  Coverage   55.61%   55.61%           
=======================================
  Files         149      149           
  Lines        8819     8819           
=======================================
  Hits         4905     4905           
  Misses       3577     3577           
  Partials      337      337           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oliviassss
Copy link
Collaborator

@johngmyers, thanks for the contribution!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2023
@oliviassss
Copy link
Collaborator

@johngmyers, sorry for the late update. We need to check with our leadership because we have internal process to merge and release PRs selectively.

@johngmyers
Copy link
Contributor Author

This would be a good topic for the Provider-AWS meeting on Friday. I would also be amenable to an unofficial meeting.

@oliviassss
Copy link
Collaborator

/lgtm
/assign @M00nF1sh

Copy link
Collaborator

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@M00nF1sh M00nF1sh merged commit 2765407 into kubernetes-sigs:main Dec 12, 2023
6 of 7 checks passed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2023
johngmyers added a commit to johngmyers/aws-load-balancer-controller that referenced this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants