-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add webhook readiness check #3375
chore: add webhook readiness check #3375
Conversation
Hi @davidkl97. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
hey @johngmyers, thanks for the review. |
It needs an approver to approve it |
hey @M00nF1sh @oliviassss, i see that you are the approvers. can you review this as well? |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
thanks a lot for making this valuable contribution.
/test pull-aws-load-balancer-controller-e2e-test |
1 similar comment
/test pull-aws-load-balancer-controller-e2e-test |
@davidkl97, can you please rebase the main branch to pick up the fix to e2e tests failure? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidkl97, M00nF1sh, oliviassss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue
Closes #2768
During installation of the controller, its starts receiving addmissions requests before the webhook is ready. This happens due to slight seconds of delay in which the webhook is starts to serve requests.
Description
The PR adds readiness probe which registers
Checker
fuction which is mapped to the webhook StartedChecker from controller-runtime framework.Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯