Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update helm chart for ServiceTargetENISGTags and README #3558

Merged
merged 1 commit into from Feb 7, 2024

Conversation

oliviassss
Copy link
Collaborator

@oliviassss oliviassss commented Feb 6, 2024

Issue

#3556
#3501

Description

  • Adds helm chart field serviceTargetENISGTags to config controller flag --service-target-eni-security-group-tags
  • Adds explanation on the use case for enabling HPA on controller
  • bumps up chart version to v1.7.1

manual test

Published the new chart to my personal eks-chart, upgraded the deployment via helm chart with the config of serviceTargetENISGTags and verified the controller was up and running with the flag set

dev-dsk-sonyingy-2c-61cf589a % helm repo update eks-test
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "eks-test" chart repository
Update Complete. ⎈Happy Helming!⎈

dev-dsk-sonyingy-2c-61cf589a % helm search repo aws-load-balancer-controller | grep eks-test
eks-test/aws-load-balancer-controller	1.7.1        	v2.7.0     	AWS Load Balancer Controller Helm chart for Kub...

dev-dsk-sonyingy-2c-61cf589a % helm upgrade -i aws-load-balancer-controller eks-test/aws-load-balancer-controller -n kube-system --set clusterName=dev-128 --set serviceTargetENISGTags=Name=my-name --set serviceAccount.create=false --set serviceAccount.name=aws-load-balancer-controller
Release "aws-load-balancer-controller" has been upgraded. Happy Helming!
NAME: aws-load-balancer-controller
LAST DEPLOYED: Tue Feb  6 00:35:36 2024
NAMESPACE: kube-system
STATUS: deployed
REVISION: 2
TEST SUITE: None
NOTES:
AWS Load Balancer controller installed!

dev-dsk-sonyingy-2c-61cf589a % k describe deployments.apps -n kube-system aws-load-balancer-controller                                             
Name:                   aws-load-balancer-controller
Namespace:              kube-system
CreationTimestamp:      Fri, 19 Jan 2024 23:34:39 +0000
Labels:                 app.kubernetes.io/instance=aws-load-balancer-controller
                        app.kubernetes.io/managed-by=Helm
                        app.kubernetes.io/name=aws-load-balancer-controller
                        app.kubernetes.io/version=v2.7.0
                        helm.sh/chart=aws-load-balancer-controller-1.7.1
...

dev-dsk-sonyingy-2c-61cf589a % k get pods -n kube-system | grep aws-load-balancer-controller
aws-load-balancer-controller-56d686f7ff-9bwz8   1/1     Running   0          46s
aws-load-balancer-controller-56d686f7ff-tpcmt   1/1     Running   0          36s
 
dev-dsk-sonyingy-2c-61cf589a % k describe deployments.apps -n kube-system aws-load-balancer-controller | grep service-target-eni-security-group-tags
      --service-target-eni-security-group-tags=Name=my-name

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 6, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ed00c81) 55.28% compared to head (0d5f45d) 55.35%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3558      +/-   ##
==========================================
+ Coverage   55.28%   55.35%   +0.07%     
==========================================
  Files         149      149              
  Lines        8950     8971      +21     
==========================================
+ Hits         4948     4966      +18     
- Misses       3664     3666       +2     
- Partials      338      339       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oliviassss oliviassss force-pushed the helm-update branch 2 times, most recently from c94f0ce to ed70b80 Compare February 6, 2024 21:56
Copy link
Collaborator

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh, oliviassss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [M00nF1sh,oliviassss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e8e9fa9 into kubernetes-sigs:main Feb 7, 2024
9 checks passed
@oliviassss oliviassss deleted the helm-update branch May 15, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants