Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TargetGroup names are not unique enough in the current state #497

Merged
merged 1 commit into from
Jul 27, 2018
Merged

TargetGroup names are not unique enough in the current state #497

merged 1 commit into from
Jul 27, 2018

Conversation

bigkraig
Copy link

Resolves #469

@bigkraig
TargetGroup names are not unique enough in the current state, if two …
7b98e25 
…services were using the same port they would conflict. This wasn't a problem when services were nodeports only.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 27, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 23.392% when pulling 7b98e25 on 469-fix into 972b6c5 on master.

@bigkraig bigkraig merged commit a6565ea into master Jul 27, 2018
@bigkraig bigkraig deleted the 469-fix branch July 27, 2018 21:46
bigkraig added a commit that referenced this pull request Oct 1, 2018
@bigkraig
Merge pull request #497 from kubernetes-sigs/469-fix
c190c07 
TargetGroup names are not unique enough in the current state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bigkraig @coveralls @k8s-ci-robot