Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2] test: add unit tests for UpdateCRIWithRetry #1517

Merged

Conversation

edreed
Copy link
Collaborator

@edreed edreed commented Sep 14, 2022

What type of PR is this?

/kind test

What this PR does / why we need it:

Adds unit test coverage for the UpdateCRIWithRetry function.

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@edreed edreed requested a review from sunpa93 September 14, 2022 23:27
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edreed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 14, 2022
@edreed edreed removed the request for review from ZeroMagic September 14, 2022 23:27
@k8s-ci-robot
Copy link
Contributor

@edreed: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azuredisk-csi-driver-external-e2e-single-az-mainv2 45ae6fb link true /test pull-azuredisk-csi-driver-external-e2e-single-az-mainv2
pull-azuredisk-csi-driver-e2e-capz-mainv2 45ae6fb link true /test pull-azuredisk-csi-driver-e2e-capz-mainv2

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@edreed edreed changed the title test: add unit tests for UpdateCRIWithRetry [V2] test: add unit tests for UpdateCRIWithRetry Sep 15, 2022
@edreed
Copy link
Collaborator Author

edreed commented Sep 15, 2022

E2E test failures are unrelated to this change - this PR contains unit test changes only.

@edreed edreed merged commit cee1ff9 into kubernetes-sigs:main_v2 Sep 15, 2022
@edreed edreed deleted the edreed-updatecriwithretry-unit-tests branch September 15, 2022 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/test size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants