New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace pkg/errors dependency #115
Replace pkg/errors dependency #115
Conversation
Welcome @ArkaSaha30! |
Hi @ArkaSaha30. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArkaSaha30, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
@ArkaSaha30 we missed those three: bom/pkg/provenance/predicate_test.go Line 22 in 5cfc466
bom/pkg/provenance/statement_test.go Line 22 in 5cfc466
Line 32 in 5cfc466
Do you mind following-up on them? |
Sure, let me fix it 👍 |
/reopen |
@ArkaSaha30: Failed to re-open PR: state cannot be changed. The pull request cannot be reopened. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Let's create a new PR for that. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
A new approach to replace the pkg/errors dependency on a package-by-package basis. Concerned packages for this PR:
pkg/provenance
magefile.go
Which issue(s) this PR fixes:
Refers to: #114
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?