New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace error handling method in pkg/license #120
replace error handling method in pkg/license #120
Conversation
pkg/license/catalog.go
Outdated
@@ -101,13 +102,17 @@ func (catalog *Catalog) WriteLicensesAsText(targetDir string) error { | |||
if err == nil { | |||
err = lerr | |||
} else { | |||
err = errors.Wrap(err, lerr.Error()) | |||
err = fmt.Errorf(lerr.Error(), err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
err = fmt.Errorf(lerr.Error(), err) | |
err = fmt.Errorf("%v: %w", lerr, err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DiptoChakrabarty, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@DiptoChakrabarty oops looks like we forgot to convert: Line 25 in a7c466f
Do you wanna follow-up on that? |
Sorry about that ill fix it |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Replaces the github.com/pkg/errors dependency with native error wrapping in the pkg/license package
Which issue(s) this PR fixes:
#114
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?