report versions correctly #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deitch
force-pushed
the
proper-version-report
branch
from
f4b4f62
to
29c98e3
Compare
displague
reviewed
Dec 15, 2021
deitch
force-pushed
the
proper-version-report
branch
from
29c98e3
to
a64ee5c
Compare
deitch
commented
Dec 15, 2021
Signed-off-by: Avi Deitcher <avi@deitcher.net>
deitch
force-pushed
the
proper-version-report
branch
from
a64ee5c
to
4019949
Compare
displague
approved these changes
Dec 15, 2021
displague
added a commit
that referenced
this pull request
Dec 17, 2021
We can use `-X "k8s.io/component-base/version/verflag.programName=Cloud Provider Equinix Metal"` to set a custom program name. This overrides the default of `Kubernetes`.
It makes more sense for `{ccm} --version` to say `Cloud Provider Equinix Metal v3.3.0` rather than `Kubernetes v3.3.0`.
This is a follow-up to the conversation in #221 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #142
Works with the Kubernetes standard versioning (without all of the branch complexity)