Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: cleanup of cpem #463

Merged
merged 2 commits into from
Oct 9, 2023
Merged

refactor: cleanup of cpem #463

merged 2 commits into from
Oct 9, 2023

Conversation

cprivitere
Copy link
Member

@cprivitere cprivitere commented Sep 26, 2023 •
edited

Refactor of the main.go to be more in line with upstream examples.

Reference examples:
https://github.com/kubernetes/cloud-provider/blob/master/sample/basic_main.go
https://github.com/kubernetes/kubernetes/blob/master/cmd/cloud-controller-manager/main.go

  • remove unnecessary random seeding
  • register json logging library
  • rename opts to ccmOptions like upstream
  • update some comments
  • remove no longer necessary pflag as well as flag normalization
  • remove no longer necessary log init lines
  • Use "cloud-provider-equinix-metal" for RBAC naming

@cprivitere
refactor: cleanup of cpem
c445233 
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 26, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cprivitere

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 26, 2023
@cprivitere
refactor: cloud-provider-equinix-metal naming
5a0708d 
- for rbac

Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
@cprivitere cprivitere merged commit 4668d02 into kubernetes-sigs:main Oct 9, 2023
5 of 6 checks passed
@cprivitere cprivitere deleted the cleanup-refactor branch October 9, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deitch deitch Awaiting requested review from deitch

@displague displague Awaiting requested review from displague

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cprivitere @k8s-ci-robot