Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removed packngo and used metal-go apis #486

Merged
merged 5 commits into from
Jan 5, 2024

Conversation

aayushrangwala
Copy link
Contributor

fixes: #439

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 13, 2023
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 13, 2023
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 13, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 13, 2023
@ctreatma
Copy link
Contributor

ctreatma commented Dec 14, 2023

There should be a go.mod change here to pull in the new SDK instead of the old one.

Now that equinix-sdk-go exists, we should adopt that instead of metal-go.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 27, 2023
@ctreatma
Copy link
Contributor

ctreatma commented Jan 2, 2024

@aayushrangwala The PR test workflow is failing with the error failed to enable BGP on project cd5ad69d-5460-46f8-8268-963262f2b8c2: undefined response type. Are you able to reproduce that failure locally?

@aayushrangwala
Copy link
Contributor Author

@aayushrangwala The PR test workflow is failing with the error failed to enable BGP on project cd5ad69d-5460-46f8-8268-963262f2b8c2: undefined response type. Are you able to reproduce that failure locally?

@ctreatma Yes I am fixing the tests for the same. Previously there was packngo packetServer which was structured for tests/interfaces and accordingly the tests were written. Changing the structure to implement bare minimum test server and fixing tests

@aayushrangwala
Copy link
Contributor Author

@ctreatma @displague Fixed all the tests. Please review and approve if looks good

Copy link
Contributor

@ctreatma ctreatma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated tests look great. I see a couple changes that look like they might not be necessary for the migration, but not sure about that. I don't have write access to this repo in any case, so we ultimately need @cprivitere to be included in the review process as well.

go.mod Outdated Show resolved Hide resolved
metal/bgp.go Outdated Show resolved Hide resolved
metal/cloud.go Show resolved Hide resolved
metal/cloud_test.go Outdated Show resolved Hide resolved
metal/cloud_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 5, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 5, 2024
Signed-off-by: Ayush Rangwala <ayush.rangwala@gmail.com>
Signed-off-by: Ayush Rangwala <ayush.rangwala@gmail.com>
Signed-off-by: Ayush Rangwala <ayush.rangwala@gmail.com>
Copy link
Member

@cprivitere cprivitere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aayushrangwala, cprivitere

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2024
Copy link
Member

@cprivitere cprivitere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2024
@cprivitere cprivitere merged commit 04a4e3c into kubernetes-sigs:main Jan 5, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace packngo with metal-go
4 participants