Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scripts for E2E testing to quickly run E2E tests. #119

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

chengxiangdong
Copy link
Member

@chengxiangdong chengxiangdong commented Oct 25, 2022

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Add scripts for E2E testing to quickly run E2E tests.

Which issue(s) this PR fixes:

Fixes #121

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 25, 2022
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 25, 2022
@chengxiangdong
Copy link
Member Author

/assign @RainbowMango

@RainbowMango
Copy link
Member

/assign

hack/pre-run-e2e.sh Outdated Show resolved Hide resolved
hack/pre-run-e2e.sh Outdated Show resolved Hide resolved
hack/pre-run-e2e.sh Outdated Show resolved Hide resolved
@RainbowMango
Copy link
Member

-bash-4.2# ls -al hack/
total 32
drwxr-xr-x  2 root root 4096 Oct 25 20:05 .
drwxr-xr-x 13 root root 4096 Oct 25 20:05 ..
-rw-r--r--  1 root root 1019 Oct 25 20:05 post-run-e2e.sh
-rw-r--r--  1 root root 6292 Oct 25 20:05 pre-run-e2e.sh
-rw-r--r--  1 root root 1435 Oct 25 20:05 run-e2e.sh
-rwxr-xr-x  1 root root 1341 Oct 19 10:49 verify-gofmt.sh
-rwxr-xr-x  1 root root  722 Oct 19 10:49 verify.sh

#115 (comment)

@chengxiangdong
Copy link
Member Author

-bash-4.2# ls -al hack/
total 32
drwxr-xr-x  2 root root 4096 Oct 25 20:05 .
drwxr-xr-x 13 root root 4096 Oct 25 20:05 ..
-rw-r--r--  1 root root 1019 Oct 25 20:05 post-run-e2e.sh
-rw-r--r--  1 root root 6292 Oct 25 20:05 pre-run-e2e.sh
-rw-r--r--  1 root root 1435 Oct 25 20:05 run-e2e.sh
-rwxr-xr-x  1 root root 1341 Oct 19 10:49 verify-gofmt.sh
-rwxr-xr-x  1 root root  722 Oct 19 10:49 verify.sh

#115 (comment)

Sorry forgot to modify permissions again, it has been corrected now.

@chengxiangdong
Copy link
Member Author

@RainbowMango
I re-pushed some changes, please review.

By the way, the account of swr.ap-southeast-1.myhuaweicloud.com/dev-registry has been sent to your gmail, and you can run E2E with your AK and SK.

@chengxiangdong chengxiangdong force-pushed the feat_e2e_script branch 2 times, most recently from e5d9d5c to 71d7c11 Compare October 28, 2022 04:41
@chengxiangdong
Copy link
Member Author

@RainbowMango
some changed code has been pushed, pls review

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chengxiangdong, RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2022
@k8s-ci-robot k8s-ci-robot merged commit dd4f889 into kubernetes-sigs:master Oct 31, 2022
@chengxiangdong chengxiangdong deleted the feat_e2e_script branch January 3, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add scripts for E2E testing to quickly run E2E tests. #119
3 participants