-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create common functions to make code more readable #139
create common functions to make code more readable #139
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chengxiangdong The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
29e4174
to
7f0560e
Compare
Lint check has a bug, I will fix it in another PR. |
41dd38f
to
a960ef0
Compare
/assign |
/lgtm |
@chengxiangdong pls resolve the conflicts first. |
a960ef0
to
b7f5af8
Compare
@niuzhenguo the code has been rebased, pls review again |
/lgtm |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: