Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add WSL2/linux support #101

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

adone
Copy link
Contributor

@adone adone commented Jul 16, 2024

It's an attempt to support WSL 2

It should be run with sudo like on any other platform tunnels required:

sudo bin/cloud-provider-kind

#100

Copy link

linux-foundation-easycla bot commented Jul 16, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: adone / name: Artem Nistratov (a380409)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 16, 2024
@k8s-ci-robot k8s-ci-robot requested a review from aojea July 16, 2024 17:21
@k8s-ci-robot
Copy link
Contributor

Welcome @adone!

It looks like this is your first PR to kubernetes-sigs/cloud-provider-kind 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cloud-provider-kind has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @adone. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 16, 2024
@BenTheElder
Copy link
Member

can we detect WSL2 and make this automatically do the right thing when in WSL2?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 16, 2024
@adone
Copy link
Contributor Author

adone commented Jul 16, 2024

it's possible

v, err := ioutil.ReadFile("/proc/version")
strings.Contains(string(v), "WSL")

I can add a function for this isWSL instead of the flag

@aojea
Copy link
Contributor

aojea commented Jul 16, 2024

it's possible

v, err := ioutil.ReadFile("/proc/version")
strings.Contains(string(v), "WSL")

I can add a function for this isWSL instead of the flag

please do that

@aojea
Copy link
Contributor

aojea commented Jul 16, 2024

/ok-to-test

also , please confirm it works

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 16, 2024
@aojea aojea marked this pull request as draft July 16, 2024 22:16
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 16, 2024
@aojea aojea marked this pull request as ready for review July 17, 2024 12:50
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 17, 2024
@k8s-ci-robot k8s-ci-robot requested a review from aojea July 17, 2024 12:50
@aojea
Copy link
Contributor

aojea commented Jul 17, 2024

almost there, left a suggestion and then please squash all commits

@aojea aojea self-assigned this Jul 17, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 17, 2024
@adone adone changed the title add new flag to enable tunnels on WSL2/linux add WSL2/linux support Jul 17, 2024
@k8s-ci-robot
Copy link
Contributor

@adone: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cloud-provider-kind-conformance-parallel-ipv6 a380409 link false /test pull-cloud-provider-kind-conformance-parallel-ipv6
pull-cloud-provider-kind-conformance-parallel-ga-only a380409 link false /test pull-cloud-provider-kind-conformance-parallel-ga-only

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@aojea
Copy link
Contributor

aojea commented Jul 17, 2024

@adone does this work for you locally?

failures on the jobs are known issues, waiting for CI for merging

@aojea
Copy link
Contributor

aojea commented Jul 17, 2024

/lgtm
/approve

Thanks for your patience and for improving the project

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adone, aojea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2024
@k8s-ci-robot k8s-ci-robot merged commit b6c63d0 into kubernetes-sigs:main Jul 17, 2024
5 of 7 checks passed
@BenTheElder
Copy link
Member

thanks!

@aojea aojea mentioned this pull request Jul 17, 2024
@adone adone deleted the linux-tunnels-for-wsl2 branch July 17, 2024 22:19
@adone
Copy link
Contributor Author

adone commented Jul 17, 2024

late reply but anyway
yep, can access services via localhost and random port from windows/browser and via curl to EXTERNAL IP from WSL2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants