-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add WSL2/linux support #101
add WSL2/linux support #101
Conversation
|
Welcome @adone! |
Hi @adone. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3fbf060
to
9219280
Compare
can we detect WSL2 and make this automatically do the right thing when in WSL2? |
it's possible
I can add a function for this |
please do that |
/ok-to-test also , please confirm it works |
almost there, left a suggestion and then please squash all commits |
13e4e27
to
a380409
Compare
@adone: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@adone does this work for you locally? failures on the jobs are known issues, waiting for CI for merging |
/lgtm Thanks for your patience and for improving the project |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adone, aojea The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thanks! |
late reply but anyway |
It's an attempt to support WSL 2
It should be run with sudo like on any other platform tunnels required:
#100