Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solve UDP crashes #68

Merged
merged 1 commit into from
May 16, 2024
Merged

solve UDP crashes #68

merged 1 commit into from
May 16, 2024

Conversation

aojea
Copy link
Contributor

@aojea aojea commented May 16, 2024

This restarts the loadbalancer container when it crashes because of envoyproxy/envoy#34195

Apparently on the restart it works fine and the test goes through.

There are a lot of hacks to deal with files and the user id for the container command is different than the one to update them, so during the restart it fails to touch the config files, since we are not worried by security on these envoys I just give them a+rw .... the goal is to move to dynamic configuration using GRPC https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/operations/dynamic_configuration so this hack will serve until then

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 16, 2024
@k8s-ci-robot
Copy link
Contributor

@aojea: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cloud-provider-kind-conformance-parallel-ipv6 607d0fb link false /test pull-cloud-provider-kind-conformance-parallel-ipv6
pull-cloud-provider-kind-conformance-parallel-ga-only 607d0fb link false /test pull-cloud-provider-kind-conformance-parallel-ga-only

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@aojea
Copy link
Contributor Author

aojea commented May 16, 2024

ok, we are down to 2 failures now

@aojea aojea merged commit ad8f473 into kubernetes-sigs:main May 16, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants