Readme for dashboard operator and updates stable version #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
stealthybox
reviewed
May 14, 2020
Comment on lines
306
to
310
| apiVersion: app.k8s.io/v1beta1 | ||
| kind: Application | ||
| metadata: | ||
| name: kubernetes-dashboard | ||
| namespace: kube-system |
There was a problem hiding this comment.
ack removal of Application CustomResource
| make run | ||
| ``` | ||
| Logs from the operator appear in the console. | ||
|
|
There was a problem hiding this comment.
Here's one more thing we can help the reader understand :)
Suggested change
| Now in another terminal, create an instance of the Dashboard custom resource: | |
| ```bash | |
| kubectl create ns kubernetes-dashboard | |
| kubectl -n kubernetes-dashboard apply -f config/samples/addons_v1alpha1_dashboard.yaml | |
| ``` | |
| You should see the operator respond and apply the resources from your package. | |
dashboard/README.md
Outdated
Comment on lines
32
to
44
| Make a directory under `channels/packages/dashboard` with the version number. For the dashboard operator the stable | ||
| version was `2.0.0` | ||
| ```bash | ||
| cd channels/packages/dashboard | ||
| mkdoir 2.0.0 | ||
| ``` | ||
|
|
||
| Download the manifest yaml | ||
| ```bash | ||
| cd 2.0.0 | ||
| wget kubectl apply -f https://raw.githubusercontent.com/kubernetes/dashboard/v2.0.0/aio/deploy/recommended.yaml | ||
| mv recommended.yaml manifest.yaml | ||
| ``` |
There was a problem hiding this comment.
Caught some small typos here /w mkdoir and kubectl apply.
It can be a bit clunky to ask a user to cd into directories, because you need to instruct them to cd back out.
Here's a simpler method:
Suggested change
| Make a directory under `channels/packages/dashboard` with the version number. For the dashboard operator the stable | |
| version was `2.0.0` | |
| ```bash | |
| cd channels/packages/dashboard | |
| mkdoir 2.0.0 | |
| ``` | |
| Download the manifest yaml | |
| ```bash | |
| cd 2.0.0 | |
| wget kubectl apply -f https://raw.githubusercontent.com/kubernetes/dashboard/v2.0.0/aio/deploy/recommended.yaml | |
| mv recommended.yaml manifest.yaml | |
| ``` | |
| Make a directory under `channels/packages/dashboard` for a stable version of the dashboard -- then download the manifest for it: | |
| ```bash | |
| mkdir -p channels/packages/dashboard/2.0.0 | |
| wget -O channels/packages/dashboard/2.0.0/manifest.yaml https://raw.githubusercontent.com/kubernetes/dashboard/v2.0.0/aio/deploy/recommended.yaml | |
| ``` | |
dashboard/README.md
Outdated
| find . -name "*_test.go" -delete | ||
| ``` | ||
|
|
||
| # Determine the a stable version and include its manifest: |
There was a problem hiding this comment.
Suggested change
| # Determine the a stable version and include its manifest: | |
| # Determine a stable version and include its manifest: |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SomtochiAma, stealthybox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.