Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flannel Operator #69

Merged
merged 8 commits into from
Jun 29, 2020
Merged

Conversation

somtochiama
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 20, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @somtochiama. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 20, 2020
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 20, 2020
@dholbach
Copy link
Member

/uncc
/cc @justinsb
/cc @stealthybox

@k8s-ci-robot k8s-ci-robot requested review from justinsb and stealthybox and removed request for dholbach June 22, 2020 07:10
@atoato88
Copy link
Contributor

/lgtm
Thank you to create PR 🎉
I confirmed that this operator creates flannel pods with DaemonSets.
I think that It's OK for initial implementation of flannel operator.

BTW, this includes manifest.yaml for flannel v0.10.0.
On upstream, latest flannel version is v0.12.0.
I'm not sure that should we use latest one, but where did you get manifests in your manifest.yaml?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2020
@somtochiama
Copy link
Member Author

/lgtm
Thank you to create PR 🎉
I confirmed that this operator creates flannel pods with DaemonSets.
I think that It's OK for initial implementation of flannel operator.

BTW, this includes manifest.yaml for flannel v0.10.0.
On upstream, latest flannel version is v0.12.0.
I'm not sure that should we use latest one, but where did you get manifests in your manifest.yaml?

I could include version 0.12.0 as the latest version. Wdyt?
The version 0.10.0 manifest can be found here: https://github.com/coreos/flannel/blob/v0.10.0/Documentation/kube-flannel.yml

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2020
@atoato88
Copy link
Contributor

/lgtm
Thank you to update.
I confirmed to work on both channel stable and latest.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2020
@justinsb
Copy link
Contributor

Wonderful, thanks @somtochiama

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, SomtochiAma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit c997888 into kubernetes-sigs:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants