Flaky unit test: TestReconcileForCluster

[mboersma]

Which jobs are flaking:

On some CI runs for PRs, the TestReconcileForCluster spec is failing, but often succeeds on /retest.

Which tests are flaking:

TestReconcileForCluster/do_not_reconcile_for_a_paused_cluster

ok  	sigs.k8s.io/cluster-api-addon-provider-helm/controllers	9.075s
--- FAIL: TestReconcileForCluster (0.00s)
    --- FAIL: TestReconcileForCluster/do_not_reconcile_for_a_paused_cluster (0.00s)
        helmchartproxy_controller_phases_test.go:321: 
            Expected
                <bool>: true
            to be false
FAIL
FAIL	sigs.k8s.io/cluster-api-addon-provider-helm/controllers/helmchartproxy	0.114s
ok  	sigs.k8s.io/cluster-api-addon-provider-helm/controllers/helmreleaseproxy	0.055s
FAIL
make: *** [Makefile:395: test] Error 1

Testgrid link:

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-addon-provider-helm/203/pull-cluster-api-addon-provider-helm-test-main/1782485852740390912

Reason for failure (if possible):

?

Anything else we need to know:

• This test was added in 🐛 Skip HelmChartProxy reconciliation for paused clusters #189 and has been flaky since it merged AFAICT.

/kind flake

[dmvolod]

Seems to it's not flaky test as it's always reproduces with go test -count=2 ./controllers/helmchartproxy/... and result from previous run influences with the current one.

[mboersma]

/assign