Remove subnet, first and last from the pool spec and create v1alpha2 Pool #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianang
force-pushed
the
remove-old-pool-fields
branch
5 times, most recently
from
35277ad
to
1ee66b5
Compare
christianang
force-pushed
the
remove-old-pool-fields
branch
from
1ee66b5
to
a8f53f8
Compare
|
@schrej I have rebased this PR and included the new changes from the pool PR. This should be ready for review. We will probably serialize PRs a bit and leave the other PRs alone until this one is merged to avoid multiple rebases since this PR is fairly significant. |
schrej
requested changes
May 8, 2023
christianang
force-pushed
the
remove-old-pool-fields
branch
2 times, most recently
from
d149cf1
to
c8d841c
Compare
schrej
reviewed
May 26, 2023
tylerschultz
force-pushed
the
remove-old-pool-fields
branch
from
c8d841c
to
fa7db20
Compare
k8s-ci-robot
added
needs-rebase
adobley
force-pushed
the
remove-old-pool-fields
branch
from
fa7db20
to
ab5ea9b
Compare
k8s-ci-robot
added
size/XXL
christianang
force-pushed
the
remove-old-pool-fields
branch
2 times, most recently
from
8d16f7a
to
add02df
Compare
- removes subnet, first, and last from the pool spec - add new converstion webhook for v1alpha1 to v1alpha2 pools Co-authored-by: Christian Ang <angc@vmware.com> Co-authored-by: Aidan Obley <aobley@vmware.com> Co-authored-by: Tyler Schultz <tschultz@vmware.com>
christianang
force-pushed
the
remove-old-pool-fields
branch
from
add02df
to
e14ee8b
Compare
|
/lgtm Thank you! And sorry that this was a bit slow, lost track of it at some point. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianang, schrej The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following what was discussed in #71. This PR removes subnet, first, and last from the pool spec in favor of a user using the new addresses field.
This PR will support a new v1alpha2 version for the InClusterIPPool and GlobalInClusterIPPool. In addition it will convert v1alpha1 resources to v1alpha2 resource using a conversion webhook. First and Last will be converted to use an addresses range in the new pool spec.
The controller and default/validation webhooks are configured to only support v1alpha2 pools and it is expected that the conversion webhook will convert v1alpha1 resources to v1alpha2 beforehand.
We have also added conversion-gen to the Makefile to support future conversions.
Fixes #71