Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm Chart CRDs Placement Causes Flaky Installations #534

Open
kahirokunn opened this issue May 24, 2024 · 8 comments
Open

Helm Chart CRDs Placement Causes Flaky Installations #534

kahirokunn opened this issue May 24, 2024 · 8 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@kahirokunn
Copy link

kahirokunn commented May 24, 2024

What steps did you take and what happened:
Attempting to install the Helm chart for cluster-api-operator results in a flaky installation process. The CRDs are located in the templates/operator-components.yaml file instead of the crds directory.

helm upgrade --install cluster-api-operator-docker cluster-api-operator/cluster-api-operator --version 0.10.1 -n cluster-api-operator-docker --create-namespace --values ./cluster-api-operator-values.yaml
Release "cluster-api-operator-docker" does not exist. Installing it now.
Error: failed post-install: warning: Hook post-install cluster-api-operator/templates/core-conditions.yaml failed: 1 error occurred:
        * Internal error occurred: failed calling webhook "vcoreprovider.kb.io": failed to call webhook: Post "https://capi-operator-webhook-service.cluster-api-operator-docker.svc:443/mutate-operator-cluster-x-k8s-io-v1alpha2-coreprovider?timeout=10s": no endpoints available for service "capi-operator-webhook-service"

What did you expect to happen:
The Helm install should complete successfully without errors.

Anything else you would like to add:
It is possible to separate the CustomResourceDefinitions from the other components using commands like the following:

cat operator-components.yaml | yq 'select(.kind != "CustomResourceDefinition")'
cat operator-components.yaml | yq 'select(.kind == "CustomResourceDefinition")'

Can we consider reorganizing the files accordingly?

Environment:

  • Cluster-api-operator version:
  • Cluster-api version:
  • Minikube/KIND version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):

/kind bug
[One or more /area labels. See https://github.com/kubernetes-sigs/cluster-api-operator/labels?q=area for the list of labels]


Feel free to fill in the specific versions and any additional environment details before submitting the issue.

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 24, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If CAPI Operator contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label May 24, 2024
@kahirokunn
Copy link
Author

kahirokunn commented May 24, 2024

We have verified that cluster-api-operator cannot be successfully installed by helm upgrade --install .
The helm install works.

@kahirokunn
Copy link
Author

It won't work if you move it as it is because CRDs uses the go template. 😢

@dtzar
Copy link

dtzar commented May 24, 2024

related to #188

@kahirokunn
Copy link
Author

Oh, Thx.

@dtzar
Copy link

dtzar commented May 25, 2024

/reopen

I think it's still worth keeping open as the team considers the design of where CRDs are placed.

@k8s-ci-robot k8s-ci-robot reopened this May 25, 2024
@k8s-ci-robot
Copy link
Contributor

@dtzar: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kahirokunn
Copy link
Author

Okay👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

3 participants