-
Notifications
You must be signed in to change notification settings - Fork 537
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #4764 from muraee/rosa-machinepool-version
✨ ROSA: Reconcile ROSAMachinePool version
- Loading branch information
Showing
18 changed files
with
552 additions
and
32 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| package v1beta2 | ||
|
|
||
| import ( | ||
| "github.com/blang/semver" | ||
| apierrors "k8s.io/apimachinery/pkg/api/errors" | ||
| runtime "k8s.io/apimachinery/pkg/runtime" | ||
| "k8s.io/apimachinery/pkg/util/validation/field" | ||
| ctrl "sigs.k8s.io/controller-runtime" | ||
| "sigs.k8s.io/controller-runtime/pkg/webhook" | ||
| "sigs.k8s.io/controller-runtime/pkg/webhook/admission" | ||
| ) | ||
|
|
||
| // SetupWebhookWithManager will setup the webhooks for the ROSAControlPlane. | ||
| func (r *ROSAControlPlane) SetupWebhookWithManager(mgr ctrl.Manager) error { | ||
| return ctrl.NewWebhookManagedBy(mgr). | ||
| For(r). | ||
| Complete() | ||
| } | ||
|
|
||
| // +kubebuilder:webhook:verbs=create;update,path=/validate-controlplane-cluster-x-k8s-io-v1beta2-rosacontrolplane,mutating=false,failurePolicy=fail,matchPolicy=Equivalent,groups=controlplane.cluster.x-k8s.io,resources=rosacontrolplanes,versions=v1beta2,name=validation.rosacontrolplanes.controlplane.cluster.x-k8s.io,sideEffects=None,admissionReviewVersions=v1;v1beta1 | ||
| // +kubebuilder:webhook:verbs=create;update,path=/mutate-controlplane-cluster-x-k8s-io-v1beta2-rosacontrolplane,mutating=true,failurePolicy=fail,matchPolicy=Equivalent,groups=controlplane.cluster.x-k8s.io,resources=rosacontrolplanes,versions=v1beta2,name=default.rosacontrolplanes.controlplane.cluster.x-k8s.io,sideEffects=None,admissionReviewVersions=v1;v1beta1 | ||
|
|
||
| var _ webhook.Defaulter = &ROSAControlPlane{} | ||
| var _ webhook.Validator = &ROSAControlPlane{} | ||
|
|
||
| // ValidateCreate implements admission.Validator. | ||
| func (r *ROSAControlPlane) ValidateCreate() (warnings admission.Warnings, err error) { | ||
| var allErrs field.ErrorList | ||
|
|
||
| if err := r.validateVersion(); err != nil { | ||
| allErrs = append(allErrs, err) | ||
| } | ||
|
|
||
| if len(allErrs) == 0 { | ||
| return nil, nil | ||
| } | ||
|
|
||
| return nil, apierrors.NewInvalid( | ||
| r.GroupVersionKind().GroupKind(), | ||
| r.Name, | ||
| allErrs, | ||
| ) | ||
| } | ||
|
|
||
| // ValidateUpdate implements admission.Validator. | ||
| func (r *ROSAControlPlane) ValidateUpdate(old runtime.Object) (warnings admission.Warnings, err error) { | ||
| var allErrs field.ErrorList | ||
|
|
||
| if err := r.validateVersion(); err != nil { | ||
| allErrs = append(allErrs, err) | ||
| } | ||
|
|
||
| if len(allErrs) == 0 { | ||
| return nil, nil | ||
| } | ||
|
|
||
| return nil, apierrors.NewInvalid( | ||
| r.GroupVersionKind().GroupKind(), | ||
| r.Name, | ||
| allErrs, | ||
| ) | ||
| } | ||
|
|
||
| // ValidateDelete implements admission.Validator. | ||
| func (r *ROSAControlPlane) ValidateDelete() (warnings admission.Warnings, err error) { | ||
| return nil, nil | ||
| } | ||
|
|
||
| func (r *ROSAControlPlane) validateVersion() *field.Error { | ||
| _, err := semver.Parse(r.Spec.Version) | ||
| if err != nil { | ||
| return field.Invalid(field.NewPath("spec.version"), r.Spec.Version, "version must be a valid semantic version") | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| // Default implements admission.Defaulter. | ||
| func (r *ROSAControlPlane) Default() { | ||
| SetObjectDefaults_ROSAControlPlane(r) | ||
| } |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.