Migrate away from using sigs.k8s.io in AWS tags

[ncdc]

/kind feature

Describe the solution you'd like
We should migrate away from using sigs.k8s.io in AWS tag names and instead use x-k8s.io. This applies to all tags prefixed with sigs.k8s.io/cluster-api-provider-aws/.

We must provide a migration path that automatically copies an old tag name to a new one, and we need to define the period of time during which we need to support both naming conventions.

Anything else you would like to add:
The prefix is defined here:

cluster-api-provider-aws/api/v1alpha2/tags.go

Line 96 in c6b8c30

NameAWSProviderPrefix = "sigs.k8s.io/cluster-api-provider-aws/"

.

Environment:

• Cluster-api-provider-aws version: v0.4.1

/priority important-longterm

[vincepri]

Next version or current v0.4.x?

[ncdc]

Not 0.4

[detiber]

I'd suggest that we maintain the backwards compat logic for the duration of the 0.5.x (or whatever the next version is) release, and then drop at v0.6.x (or vNext +1)

[vincepri]

Wouldn’t an upgrade tool or document handle covering the breaking change? I wonder if it’s worth maintaining backward logic while we are in alpha phase

[detiber]

Wouldn’t an upgrade tool or document handle covering the breaking change? I wonder if it’s worth maintaining backward logic while we are in alpha phase

We need to start to make a clear distinction between the alpha version of the types and the support that we provide for the greater project, which IMO is beyond alpha at this point.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[detiber]

/lifecycle frozen

[richardcase]

/remove-lifecycle frozen

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[richardcase]

/remove-lifecycle stale

[Ankitasw]

Looks like a breaking change.
@richardcase shall we add this item to v1beta3 APIs issue?

[richardcase]

@Ankitasw - yes good idea 👍

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[Ankitasw]

/remove-lifecycle stale