Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression of max resync for EKS #2845

Closed
richardcase opened this issue Oct 13, 2021 · 2 comments · Fixed by #2846
Closed

Regression of max resync for EKS #2845

richardcase opened this issue Oct 13, 2021 · 2 comments · Fixed by #2846
Assignees
@richardcase
Labels
area/provider/eks Issues or PRs related to Amazon EKS provider kind/regression Categorizes issue or PR as related to a regression from a prior release. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@richardcase
Copy link
Member

/kind regression
/area provider/eks
/priority critical-urgent

Describe the solution you'd like
When EKS was graduated the check for the max resync period wasn't added. We need to include this as it will potentially cause token expired issues with anything that relies on the kubeconfig (i.e. crs, scaling).

This will need to be back ported to 0.7.x as well.

Environment:

  • Cluster-api-provider-aws version: 1.0.0 * 0.7.0
@k8s-ci-robot k8s-ci-robot added kind/regression Categorizes issue or PR as related to a regression from a prior release. area/provider/eks Issues or PRs related to Amazon EKS provider priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 13, 2021
@richardcase
Copy link
Member Author

/assign
/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Oct 13, 2021
@richardcase
Copy link
Member Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 13, 2021
This was referenced Oct 13, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richardcase richardcase

Labels
area/provider/eks Issues or PRs related to Amazon EKS provider kind/regression Categorizes issue or PR as related to a regression from a prior release. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: added may resync check for EKS
2 participants
@richardcase @k8s-ci-robot