Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport] fix: added may resync check for EKS #2847

Closed
wants to merge 1 commit into from
Closed

[backport] fix: added may resync check for EKS #2847

wants to merge 1 commit into from

Conversation

richardcase
Copy link
Member

What type of PR is this?

/kind regression

What this PR does / why we need it:

When EKS was graduated the check to make sure that the
max sync time wasn't greater than 10 mins was missed.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Relates #2845

Special notes for your reviewer:

Checklist:

  • squashed commits

Release note:

Reinstating the check for the maximum allowed resync period when EKS is enabled.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/regression Categorizes issue or PR as related to a regression from a prior release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from richardcase after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

@richardcase: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 13, 2021
@dlipovetsky
Copy link
Contributor

Before merging, please copy changes you make in #2846!

Thanks for fixing.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2021
@richardcase
fix: added may resync check for EKS
2d11c82 
When EKS was graduated the check to make sure that the
max sync time wasn't greater than 10 mins was missed.

Signed-off-by: Richard Case <richard@weave.works>
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2021
@richardcase
Copy link
Member Author

Review comments from #2846 have been incorporated.

@richardcase richardcase changed the base branch from main to release-0.7 October 18, 2021 14:10
@randomvariable
Copy link
Member

/cherry-pick release-0.7

@randomvariable
Copy link
Member

/close
Testing the cherrypick plugin for prow in
#2856

@k8s-ci-robot
Copy link
Contributor

@randomvariable: Closed this PR.

In response to this:

/close
Testing the cherrypick plugin for prow in
#2856

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlipovetsky dlipovetsky Awaiting requested review from dlipovetsky

@randomvariable randomvariable Awaiting requested review from randomvariable

Assignees

@dlipovetsky dlipovetsky

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/regression Categorizes issue or PR as related to a regression from a prior release. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@richardcase @k8s-ci-robot @dlipovetsky @randomvariable