Consider if to add --metrics-bind-addr=127.0.0.1:8080 in manager.yaml

[fabriziopandini]

While working on kubernetes-sigs/cluster-api#6117 we noticed that latest CAPA doesn't have "--metrics-bind-addr=127.0.0.1:8080" in your manager.yaml (see
https://cluster-api.sigs.k8s.io/developer/providers/v0.3-to-v0.4.html#required-kustomize-changes-to-have-a-single-manager-watching-all-namespaces-and-answer-to-webhook-calls).

Applying this change is not mandatory, but FYI deploying Prometheus in local dev env using the CAPI Tiltfile won't work without this change.

[k8s-ci-robot]

@fabriziopandini: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sedefsavas]

Thanks @fabriziopandini

We had this in v1alpha4, but not have it in v1beta1.

This is a simple change, we need to add this line:

cluster-api-provider-aws/config/manager/manager.yaml

Line 21 in de756c7

- "--metrics-bind-addr=127.0.0.1:8080"

and this
https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/v0.7.3/config/rbac/auth_proxy_service.yaml

/good-first-issue
/triage-accepted
/priority backlog
/milestone v1.x

[k8s-ci-robot]

@sedefsavas:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Thanks @fabriziopandini

We had this in v1alpha4, but not have it in v1beta1.

This is a simple change, we need to add this line:

cluster-api-provider-aws/config/manager/manager.yaml

Line 21 in de756c7

- "--metrics-bind-addr=127.0.0.1:8080"

and this
https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/v0.7.3/config/rbac/auth_proxy_service.yaml

/good-first-issue
/triage-accepted
/priority backlog
/milestone v1.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Matheusafonsouza]

Can i be responsible for this one?

[Matheusafonsouza]

/assign