Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up internet-facing loadbalancer scheme logic #3673

Closed
sedefsavas opened this issue Aug 16, 2022 · 4 comments · Fixed by #3832
Closed

Clean up internet-facing loadbalancer scheme logic #3673

sedefsavas opened this issue Aug 16, 2022 · 4 comments · Fixed by #3832
Assignees
@sedefsavas @Ankitasw
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
v2.0.0

Comments

@sedefsavas
Copy link
Contributor

To fix a casing issue (#2768), we had some custom logic implemented here.

With v1beta2 API version, we no longer need this custom logic as users were not allowed to use the incorrect LB scheme (Internet-facing) in v1beta1.

/triage accepted
/priority important-soon
/milestone v2.x
/assign
@k8s-ci-robot k8s-ci-robot added this to the v2.x milestone Aug 16, 2022
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Aug 16, 2022
@sedefsavas sedefsavas mentioned this issue Aug 16, 2022
Closed
4 tasks
@Ankitasw
Copy link
Member

Ankitasw commented Nov 9, 2022

/milestone v2.0.0

@k8s-ci-robot
Copy link
Contributor

@Ankitasw: You must be a member of the kubernetes-sigs/cluster-api-provider-aws-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Cluster API Provider AWS Maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v2.0.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Ankitasw
Copy link
Member

Ankitasw commented Nov 9, 2022

/assign

@Ankitasw Ankitasw mentioned this issue Nov 9, 2022
Merged
4 tasks
@richardcase
Copy link
Member

/milestone v2.0.0

@k8s-ci-robot k8s-ci-robot modified the milestones: v2.x, v2.0.0 Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sedefsavas sedefsavas

@Ankitasw Ankitasw

Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

Clean up internet-facing loadbalancer scheme logic Ankitasw/cluster-api-provider-aws
4 participants
@richardcase @k8s-ci-robot @sedefsavas @Ankitasw