Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid annotation key for sigs.k8s.io/cluster-api-provider-aws/v2-last-applied-tags #3863

Closed
tmad opened this issue Nov 18, 2022 · 1 comment · Fixed by #3867
Closed

Invalid annotation key for sigs.k8s.io/cluster-api-provider-aws/v2-last-applied-tags #3863

tmad opened this issue Nov 18, 2022 · 1 comment · Fixed by #3867
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@tmad
Copy link

tmad commented Nov 18, 2022

/kind bug

What steps did you take and what happened:
Upgraded to v2.0.0 with clusterctl

Looked into cluster-api-provider-aws logs. There were issues like:
Invalid value: \"sigs.k8s.io/cluster-api-provider-aws/v2-last-applied-tags\" a qualified name must consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyName', or 'my.name', or '123-abc', regex used for validation is '([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9]') with an optional DNS subdomain prefix and '/' (e.g. 'example.com/MyName')

Anything else you would like to add:
The issue is probably caused by two slashes appearing in the new annotations instead of one.
This may be appearing when using additionalTags.

  • controllers/awsmachine_tags.go - TagsLastAppliedAnnotation = "sigs.k8s.io/cluster-api-provider-aws/v2-last-applied-tags"
  • pkg/cloud/services/ec2/launchtemplate.go - TagsLastAppliedAnnotation = "sigs.k8s.io/cluster-api-provider-aws/v2-last-applied-tags"
  • controllers/awsmachine_security_groups.go - SecurityGroupsLastAppliedAnnotation = "sigs.k8s.io/cluster-api-provider-aws/v2-last-applied-security-groups"

Environment:

  • Cluster-api-provider-aws version: 2.00
  • Kubernetes version: (use kubectl version): 1.23
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 18, 2022
@k8s-ci-robot
Copy link
Contributor

@tmad: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dntosas added a commit to dntosas/cluster-api-provider-aws that referenced this issue Nov 21, 2022
Valid annotation keys have two segments: an optional prefix and name,
separated by a slash (/). In this commit, we fix the ones that include
two slashes that couldn't be parsed as valid structs.

Closes kubernetes-sigs#3863

Signed-off-by: Jim Ntosas <ntosas@gmail.com>
k8s-infra-cherrypick-robot pushed a commit to k8s-infra-cherrypick-robot/cluster-api-provider-aws that referenced this issue Nov 22, 2022
Valid annotation keys have two segments: an optional prefix and name,
separated by a slash (/). In this commit, we fix the ones that include
two slashes that couldn't be parsed as valid structs.

Closes kubernetes-sigs#3863

Signed-off-by: Jim Ntosas <ntosas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants