New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not include input object in the error message #1024
Do not include input object in the error message #1024
Conversation
Signed-off-by: Joonas Bergius <jbergius@vmware.com>
Welcome @joonas! |
Hi @joonas. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Nice 🎉 !
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joonas, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ssage Do not include input object in the error message
What this PR does / why we need it:
It was pointed out in #1022 that the returned error message also includes the input instance in the error message, while this provides additional information about what the inputs going in were, it makes the returned error message more difficult to parse.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1022
Special notes for your reviewer:
If we would like to still provide the given inputs as debug information, I would be happy to look at adding separate debug logging that contains that information.
Also, if this is deemed to be a good approach for handling this, I'm happy to open up a similar patch against master.