New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--partition flag for clusterawsadm #1029
--partition flag for clusterawsadm #1029
Conversation
Hi @aaroniscode. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/ok-to-test
/assign @detiber
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aaroniscode, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We'd also need to backport this change to |
@vincepri I've got that ready. Do I just open a separate pull request on that branch? |
Correct! |
/lgtm |
What this PR does / why we need it:
Currently,
clusterawsadm
can create IAM policies for the stardard AWS regions. For AWS GovCloud and AWS China, the ARN needs to updated with a specific partition name. From the AWS documentation:Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #959
Special notes for your reviewer:
I'm not super familiar with Cobra, so let me know if there is a different convention I should use for setting the flag and retrieving it's value.
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: