Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--partition flag for clusterawsadm #1029

Merged
merged 1 commit into from Aug 19, 2019
Merged

--partition flag for clusterawsadm #1029

merged 1 commit into from Aug 19, 2019

Conversation

aaroniscode
Copy link
Contributor

What this PR does / why we need it:
Currently, clusterawsadm can create IAM policies for the stardard AWS regions. For AWS GovCloud and AWS China, the ARN needs to updated with a specific partition name. From the AWS documentation:

AWS accounts are scoped to a single partition. You can get a partition by name. Valid partition names include:

"aws" - Public AWS partition
"aws-cn" - AWS China
"aws-us-gov" - AWS GovCloud

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #959

Special notes for your reviewer:
I'm not super familiar with Cobra, so let me know if there is a different convention I should use for setting the flag and retrieving it's value.

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

clusterawsadm: Support for different AWS partitions, including AWS GovCloud, using the --partition flag

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 17, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @aaroniscode. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 17, 2019
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/ok-to-test
/assign @detiber

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aaroniscode, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2019
@vincepri
Copy link
Member

We'd also need to backport this change to release-0.3 branch.

@aaroniscode
Copy link
Contributor Author

We'd also need to backport this change to release-0.3 branch.

@vincepri I've got that ready. Do I just open a separate pull request on that branch?

@vincepri
Copy link
Member

Correct!

@detiber
Copy link
Member

detiber commented Aug 19, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8056905 into kubernetes-sigs:master Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support alternative identity partitions for IAM roles
4 participants