Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store cluster status and remove pointers #106

Merged
merged 1 commit into from Sep 25, 2018
Merged

Store cluster status and remove pointers #106

merged 1 commit into from Sep 25, 2018

Conversation

vincepri
Copy link
Member

@vincepri vincepri commented Sep 25, 2018 •
edited

Fixed #103

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 25, 2018
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 25, 2018
@vincepri vincepri requested review from chuckha and removed request for ingvagabund September 25, 2018 19:07
chuckha
chuckha approved these changes Sep 25, 2018
View reviewed changes
Copy link
Contributor

@chuckha chuckha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job getting mockgen to output the right packages :)

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckha, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2018
@vincepri vincepri mentioned this pull request Sep 25, 2018
Closed
@chuckha
Copy link
Contributor

chuckha commented Sep 25, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2018
@chuckha chuckha mentioned this pull request Sep 25, 2018
Closed
@k8s-ci-robot k8s-ci-robot merged commit 3ba156b into kubernetes-sigs:master Sep 25, 2018
@vincepri vincepri deleted the actuator-pointers branch October 15, 2018 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuckha chuckha chuckha approved these changes

@detiber detiber Awaiting requested review from detiber

Assignees

@chuckha chuckha

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vincepri @k8s-ci-robot @chuckha