Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 Specify controller manager broadcaster options so events do not get discarded #1124

Merged
merged 1 commit into from Sep 30, 2019
Merged

馃悰 Specify controller manager broadcaster options so events do not get discarded #1124

merged 1 commit into from Sep 30, 2019

Conversation

liztio
Copy link
Contributor

@liztio liztio commented Sep 11, 2019

What this PR does / why we need it:
Currently we are losing deletion events if they occur soon after cluster creation, and possibly other events we don't know about. This ups the limits of events reported in a given window so all events are submitted to the Kubernetes API.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1068

LAST SEEN   TYPE     REASON                                         OBJECT                    MESSAGE
0s          Normal   SuccessfulTerminateBastion                     awscluster/cloudsdale     Terminated bastion instance "i-00c033cbffee6efb2"
0s          Normal   SuccessfulRevokeSecurityGroupIngressRules      awscluster/cloudsdale     Revoked all security group ingress rules for SecurityGroup "sg-068b5223284fa2d3f"
0s          Normal   SuccessfulRevokeSecurityGroupIngressRules      awscluster/cloudsdale     Revoked all security group ingress rules for SecurityGroup "sg-09a9175ae1c4be1cf"
0s          Normal   SuccessfulRevokeSecurityGroupIngressRules      awscluster/cloudsdale     Revoked all security group ingress rules for SecurityGroup "sg-0b09d605380c9dbae"
0s          Normal   SuccessfulDeleteSecurityGroup                  awscluster/cloudsdale     Deleted managed SecurityGroup "sg-068b5223284fa2d3f"
0s          Normal   SuccessfulDeleteSecurityGroup                  awscluster/cloudsdale     Deleted managed SecurityGroup "sg-09a9175ae1c4be1cf"
0s          Normal   SuccessfulDeleteSecurityGroup                  awscluster/cloudsdale     Deleted managed SecurityGroup "sg-0544716706954d455"
0s          Normal   SuccessfulDeleteSecurityGroup                  awscluster/cloudsdale     Deleted managed SecurityGroup "sg-0b09d605380c9dbae"
0s          Normal   SuccessfulDisassociateRouteTable               awscluster/cloudsdale     Disassociated managed RouteTable "rtb-0260c34683d99c074" from subnet "subnet-095669e86ce13f6c3"
0s          Normal   SuccessfulDeleteRouteTable                     awscluster/cloudsdale     Deleted managed RouteTable "rtb-0260c34683d99c074"
0s          Normal   SuccessfulDisassociateRouteTable               awscluster/cloudsdale     Disassociated managed RouteTable "rtb-0be4e33c7fc607186" from subnet "subnet-00e1f050ae7b80e54"
0s          Normal   SuccessfulDeleteRouteTable                     awscluster/cloudsdale     Deleted managed RouteTable "rtb-0be4e33c7fc607186"
0s          Normal   SuccessfulDeleteNATGateway                     awscluster/cloudsdale     Deleted NAT Gateway "nat-020551e2af7c5527f" previously attached to VPC "vpc-00d3bada5d55a68f2"
0s          Normal   SuccessfulDeleteSecurityGroup                  awscluster/cloudsdale     Deleted managed SecurityGroup "sg-0544716706954d455"
0s          Normal   SuccessfulDeleteSecurityGroup                  awscluster/cloudsdale     Deleted managed SecurityGroup "sg-0b09d605380c9dbae"
0s          Normal   SuccessfulDeleteSecurityGroup                  awscluster/cloudsdale     Deleted managed SecurityGroup "sg-068b5223284fa2d3f"
0s          Normal   SuccessfulDeleteSecurityGroup                  awscluster/cloudsdale     Deleted managed SecurityGroup "sg-09a9175ae1c4be1cf"
0s          Normal   SuccessfulDetachInternetGateway                awscluster/cloudsdale     Detached Internet Gateway "igw-0c4e72f9d77264fba" from VPC "vpc-00d3bada5d55a68f2"
0s          Normal   SuccessfulDeleteInternetGateway                awscluster/cloudsdale     Deleted Internet Gateway "igw-0c4e72f9d77264fba" previously attached to VPC "vpc-00d3bada5d55a68f2"
0s          Normal   SuccessfulDeleteSubnet                         awscluster/cloudsdale     Deleted managed Subnet "subnet-00e1f050ae7b80e54"
0s          Normal   SuccessfulDeleteSubnet                         awscluster/cloudsdale     Deleted managed Subnet "subnet-095669e86ce13f6c3"
0s          Normal   SuccessfulDeleteVPC                            awscluster/cloudsdale     Deleted managed VPC "vpc-00d3bada5d55a68f2"

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 11, 2019
@liztio
Copy link
Contributor Author

liztio commented Sep 11, 2019

/cc @ncdc @detiber

@liztio
Copy link
Contributor Author

liztio commented Sep 11, 2019

heads up to reviewers: I am on holiday until September 25th. If you have feedback, feel free to cherry-pick this branch!

detiber
detiber reviewed Sep 11, 2019
View reviewed changes
Copy link
Member

@detiber detiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits on the go.mod changes, otherwise this looks great :)

go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@ncdc
Copy link
Contributor

ncdc commented Sep 12, 2019

@detiber do you want to merge & then do a follow-up, or close and open a replacement?

ncdc
ncdc reviewed Sep 12, 2019
View reviewed changes
main.go Outdated Show resolved Hide resolved
@ncdc ncdc added this to the v0.4.x milestone Sep 23, 2019
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 27, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 27, 2019
vincepri
vincepri reviewed Sep 27, 2019
View reviewed changes
go.mod Show resolved Hide resolved
@liztio liztio force-pushed the disable-event-throttling branch 9 times, most recently from 55980f6 to d144d60 Compare September 27, 2019 19:45
vincepri
vincepri approved these changes Sep 27, 2019
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/assign @ncdc
for final lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liztio, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2019
ncdc
ncdc reviewed Sep 27, 2019
View reviewed changes
main.go Show resolved Hide resolved
vincepri
vincepri approved these changes Sep 30, 2019
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2019
@vincepri vincepri changed the title 馃悰 Manually specify broadcaster options so events do not get discarded 馃悰 Specify controller manager broadcaster options so events do not get discarded Sep 30, 2019
@vincepri vincepri changed the title 馃悰 Specify controller manager broadcaster options so events do not get discarded 馃悰 Specify controller manager broadcaster options so events do not get discarded Sep 30, 2019
@k8s-ci-robot k8s-ci-robot merged commit d97a8ce into kubernetes-sigs:master Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncdc ncdc ncdc left review comments

@detiber detiber detiber left review comments

@vincepri vincepri vincepri approved these changes

@davidewatson davidewatson Awaiting requested review from davidewatson

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

Assignees

@ncdc ncdc

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4.x
Development

Successfully merging this pull request may close these issues.

Losing AWSCluster events on deletion
5 participants
@liztio @ncdc @k8s-ci-robot @detiber @vincepri