Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰Do not attempt to log NAT gateway ID when creation fails #1213

Merged
merged 1 commit into from
Oct 14, 2019
Merged

馃悰Do not attempt to log NAT gateway ID when creation fails #1213

merged 1 commit into from
Oct 14, 2019

Conversation

alexbrand
Copy link
Contributor

What this PR does / why we need it:
To avoid a nil pointer dereference error, do not attempt to log the NAT
gateway ID when we get an error back from the AWS client.

Which issue(s) this PR fixes
Fixes #1209

@alexbrand
Do not attempt to log NAT gateway ID when creation fails
34d21a0 
To avoid a nil pointer dereference error, do not attempt to log the NAT
gateway ID when we get an error back from the AWS client.

Signed-off-by: Alexander Brand <alexbrand09@gmail.com>
@k8s-ci-robot
Copy link
Contributor

Welcome @alexbrand!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-aws 馃帀. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 馃槂

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 14, 2019
@ncdc ncdc self-assigned this Oct 14, 2019
@ncdc
Copy link
Contributor

ncdc commented Oct 14, 2019

Thanks!

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexbrand, ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ncdc ncdc added this to the v0.5.0 milestone Oct 14, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2019
@k8s-ci-robot k8s-ci-robot merged commit 468f1d6 into kubernetes-sigs:master Oct 14, 2019
@ncdc ncdc mentioned this pull request Oct 14, 2019
Closed
@alexbrand alexbrand deleted the fix-natgateways branch October 14, 2019 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashish-amarnath ashish-amarnath Awaiting requested review from ashish-amarnath

@detiber detiber Awaiting requested review from detiber

Assignees

@ncdc ncdc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.

Crash when trying to create NAT gateway
3 participants
@alexbrand @k8s-ci-robot @ncdc