Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰Fixes clusterawsadm version command #1232

Merged
merged 1 commit into from
Oct 21, 2019
Merged

馃悰Fixes clusterawsadm version command #1232

merged 1 commit into from
Oct 21, 2019

Conversation

aaroniscode
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1013

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 20, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @aaroniscode. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 20, 2019
@aaroniscode
Copy link
Contributor Author

I'm interested in your thoughts on this approach. I took the git version environment variable code in print-workspace-status.sh and moved it into a the version::get_version_vars() function in hack/version.sh. I modeled that file from k8s.io/hack/lib/version.sh.

I'm new to Go's ldflags and not familiar with the history of the print-workspace-status.sh script. Happy to change approach if necessary.

@randomvariable
Copy link
Member

print-workspace-status.sh derivates from when Bazel was being used.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 21, 2019
ncdc
ncdc reviewed Oct 21, 2019
View reviewed changes
hack/print-workspace-status.sh Outdated
@@ -17,58 +17,10 @@ set -o errexit
set -o nounset
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we delete this file?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, yes, I think so.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ncdc I left the print-workspace-status.sh file as I wasn't sure what it was used for. But happy to delete it if it's not needed any more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete away!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted!

@randomvariable
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2019
@ncdc ncdc added this to the v0.5.0 milestone Oct 21, 2019
@ncdc
Copy link
Contributor

ncdc commented Oct 21, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aaroniscode, ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2019
@k8s-ci-robot k8s-ci-robot merged commit aa0b18e into kubernetes-sigs:master Oct 21, 2019
@ncdc ncdc mentioned this pull request Oct 22, 2019
Closed
@aaroniscode aaroniscode mentioned this pull request Dec 11, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncdc ncdc ncdc left review comments

@randomvariable randomvariable randomvariable left review comments

@ashish-amarnath ashish-amarnath Awaiting requested review from ashish-amarnath

@sethp-nr sethp-nr Awaiting requested review from sethp-nr

Assignees

@randomvariable randomvariable

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.

Release artifact clusterawsadm reports a missing or incorrect version
4 participants
@aaroniscode @k8s-ci-robot @randomvariable @ncdc