🐛 Disassociate Elastic IPs on deletion, if still associated #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
randomvariable
changed the title
detiber
reviewed
Oct 24, 2019
|
/milestone v0.5.0 |
k8s-ci-robot
added
size/M
randomvariable
force-pushed
the
disassociate-eip
branch
from
2b4f3c2
to
14908e2
Compare
vincepri
approved these changes
Oct 25, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: randomvariable, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retitle 🐛 Disassociate Elastic IPs on deletion, if still associated |
k8s-ci-robot
changed the title
|
@randomvariable Can you squash down to 1 commit? |
|
lgtm once commits are squashed. |
Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
randomvariable
force-pushed
the
disassociate-eip
branch
from
14908e2
to
3308e67
Compare
|
Squasheeed |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Disassociate an Elastic IP if it is still associated, most commonly with an ELB
that is no longer visible in the API after deletion.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1185
For release note: