馃悰 Wait for cert-manager in make create-cluster-management
#1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
detiber
reviewed
Oct 31, 2019
Makefile
Outdated
| @@ -315,7 +315,13 @@ create-cluster-management: $(CLUSTERCTL) ## Create a development Kubernetes clus | |||
| # Apply provider-components. | |||
| kubectl \ | |||
| --kubeconfig=$$(kind get kubeconfig-path --name="clusterapi") \ | |||
| create -f examples/_out/provider-components.yaml | |||
| create -f examples/_out/provider-components.yaml || true | |||
There was a problem hiding this comment.
Suggested change
| create -f examples/_out/provider-components.yaml || true | |
| create -f examples/_out/provider-components.yaml |
We should not continue if applying the provider components fails.
There was a problem hiding this comment.
currently cert-manager manifests are added to provider-components.yaml. So should we deploy cert-manager first from capi/config/certmanager, wait for pods to be ready and then apply provider-components.yaml?
There was a problem hiding this comment.
Yes, I believe that should be the correct ordering.
There was a problem hiding this comment.
Then we get this error, cert-manager manifests already exists :|
namespace/capi-system created
customresourcedefinition.apiextensions.k8s.io/awsclusters.infrastructure.cluster.x-k8s.io created
customresourcedefinition.apiextensions.k8s.io/awsmachines.infrastructure.cluster.x-k8s.io created
customresourcedefinition.apiextensions.k8s.io/awsmachinetemplates.infrastructure.cluster.x-k8s.io created
customresourcedefinition.apiextensions.k8s.io/clusters.cluster.x-k8s.io created
customresourcedefinition.apiextensions.k8s.io/kubeadmconfigs.bootstrap.cluster.x-k8s.io created
customresourcedefinition.apiextensions.k8s.io/kubeadmconfigtemplates.bootstrap.cluster.x-k8s.io created
customresourcedefinition.apiextensions.k8s.io/machinedeployments.cluster.x-k8s.io created
customresourcedefinition.apiextensions.k8s.io/machines.cluster.x-k8s.io created
customresourcedefinition.apiextensions.k8s.io/machinesets.cluster.x-k8s.io created
role.rbac.authorization.k8s.io/capa-leader-election-role created
role.rbac.authorization.k8s.io/capi-leader-election-role created
clusterrole.rbac.authorization.k8s.io/capa-manager-role created
clusterrole.rbac.authorization.k8s.io/capa-proxy-role created
clusterrole.rbac.authorization.k8s.io/capi-manager-role created
rolebinding.rbac.authorization.k8s.io/capa-leader-election-rolebinding created
rolebinding.rbac.authorization.k8s.io/capi-leader-election-rolebinding created
clusterrolebinding.rbac.authorization.k8s.io/capa-manager-rolebinding created
clusterrolebinding.rbac.authorization.k8s.io/capa-proxy-rolebinding created
clusterrolebinding.rbac.authorization.k8s.io/capi-manager-rolebinding created
secret/capa-manager-bootstrap-credentials created
service/capa-controller-manager-metrics-service created
service/capa-webhook-service created
deployment.apps/capa-controller-manager created
deployment.apps/capi-controller-manager created
certificate.certmanager.k8s.io/capa-serving-cert created
issuer.certmanager.k8s.io/capa-selfsigned-issuer created
validatingwebhookconfiguration.admissionregistration.k8s.io/capa-validating-webhook-configuration created
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": namespaces "cert-manager" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": customresourcedefinitions.apiextensions.k8s.io "certificaterequests.certmanager.k8s.io" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": customresourcedefinitions.apiextensions.k8s.io "certificates.certmanager.k8s.io" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": customresourcedefinitions.apiextensions.k8s.io "challenges.certmanager.k8s.io" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": customresourcedefinitions.apiextensions.k8s.io "clusterissuers.certmanager.k8s.io" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": customresourcedefinitions.apiextensions.k8s.io "issuers.certmanager.k8s.io" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": customresourcedefinitions.apiextensions.k8s.io "orders.certmanager.k8s.io" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": mutatingwebhookconfigurations.admissionregistration.k8s.io "cert-manager-webhook" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": serviceaccounts "cert-manager" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": serviceaccounts "cert-manager-cainjector" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": serviceaccounts "cert-manager-webhook" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": clusterroles.rbac.authorization.k8s.io "cert-manager-edit" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": clusterroles.rbac.authorization.k8s.io "cert-manager-view" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": clusterroles.rbac.authorization.k8s.io "cert-manager-webhook:webhook-requester" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": clusterroles.rbac.authorization.k8s.io "cert-manager-cainjector" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": clusterroles.rbac.authorization.k8s.io "cert-manager-controller-certificates" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": clusterroles.rbac.authorization.k8s.io "cert-manager-controller-challenges" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": clusterroles.rbac.authorization.k8s.io "cert-manager-controller-clusterissuers" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": clusterroles.rbac.authorization.k8s.io "cert-manager-controller-ingress-shim" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": clusterroles.rbac.authorization.k8s.io "cert-manager-controller-issuers" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": clusterroles.rbac.authorization.k8s.io "cert-manager-controller-orders" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": clusterroles.rbac.authorization.k8s.io "cert-manager-leaderelection" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": rolebindings.rbac.authorization.k8s.io "cert-manager-webhook:webhook-authentication-reader" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": clusterrolebindings.rbac.authorization.k8s.io "cert-manager-cainjector" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": clusterrolebindings.rbac.authorization.k8s.io "cert-manager-controller-certificates" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": clusterrolebindings.rbac.authorization.k8s.io "cert-manager-controller-challenges" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": clusterrolebindings.rbac.authorization.k8s.io "cert-manager-controller-clusterissuers" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": clusterrolebindings.rbac.authorization.k8s.io "cert-manager-controller-ingress-shim" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": clusterrolebindings.rbac.authorization.k8s.io "cert-manager-controller-issuers" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": clusterrolebindings.rbac.authorization.k8s.io "cert-manager-controller-orders" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": clusterrolebindings.rbac.authorization.k8s.io "cert-manager-leaderelection" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": clusterrolebindings.rbac.authorization.k8s.io "cert-manager-webhook:auth-delegator" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": services "cert-manager" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": services "cert-manager-webhook" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": deployments.apps "cert-manager" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": deployments.apps "cert-manager-cainjector" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": deployments.apps "cert-manager-webhook" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": apiservices.apiregistration.k8s.io "v1beta1.webhook.certmanager.k8s.io" already exists
Error from server (AlreadyExists): error when creating "examples/_out/provider-components.yaml": validatingwebhookconfigurations.admissionregistration.k8s.io "cert-manager-webhook" already exists
make: *** [Makefile:319: create-cluster-management] Error 1
There was a problem hiding this comment.
Ah, this is because the target that is building the provider components is adding the cert manager manifests... I'm wondering if we should not use that target for this step and instead build the manifests with kustomize here instead?
There was a problem hiding this comment.
Where are these CRDs getting added?
tahsinrahman
force-pushed
the
fix-make-mgmt-cluster
branch
from
5b44d40
to
1f23eb6
Compare
tahsinrahman
force-pushed
the
fix-make-mgmt-cluster
branch
from
1f23eb6
to
bb0dcd3
Compare
tahsinrahman
commented
Oct 31, 2019
| --kubeconfig=$$(kind get kubeconfig-path --name="clusterapi") \ | ||
| wait --for=condition=Ready --namespace=cert-manager --timeout=15m pods --all | ||
| # Wait for webhook servers to be ready to take requests | ||
| sleep 10 |
There was a problem hiding this comment.
This sleep is to avoid this error
Error from server (InternalError): error when creating "examples/_out/provider-components.yaml": Internal error occurred: failed calling webhook "webhook.cert-manager.io": the server is currently unable to handle the request
Error from server (InternalError): error when creating "examples/_out/provider-components.yaml": Internal error occurred: failed calling webhook "webhook.cert-manager.io": the server is currently unable to handle the request
vincepri
reviewed
Oct 31, 2019
| @@ -304,7 +304,14 @@ create-cluster-management: $(CLUSTERCTL) ## Create a development Kubernetes clus | |||
| kubectl \ | |||
| --kubeconfig=$$(kind get kubeconfig-path --name="clusterapi") \ | |||
| create -f https://github.com/jetstack/cert-manager/releases/download/v0.11.0/cert-manager.yaml | |||
| # Wait for cert-manager pods to be created | |||
| sleep 20 | |||
There was a problem hiding this comment.
this sleep is here as pods are not created instantly, kubectl wait complains that no pod found
# Wait for cert-manager pods to be ready.
kubectl \
--kubeconfig=$(kind get kubeconfig-path --name="clusterapi") \
wait --for=condition=Ready --namespace=cert-manager --timeout=15m pods --all
error: no matching resources found
|
/approve |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, tahsinrahman, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix this error
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #