-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ AWSCluster: Allow setting ImageLookupOrg at the cluster level #1309
✨ AWSCluster: Allow setting ImageLookupOrg at the cluster level #1309
Conversation
Hi @alexbrand. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/lgtm
@detiber I noticed that the CRD yaml got restructured a bit in this PR. Is that expected? |
Yes, this is the first divergence that I'm aware of with v1alpha2 -> v1alpha3, so this is expected :) |
Got it! Thanks @detiber |
/assign @ncdc |
Signed-off-by: Alexander Brand <alexbrand09@gmail.com>
347c0de
to
27cd81b
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexbrand, detiber The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR adds a new field,
ImageLookupOrg
, to theAWSClusterSpec
struct. TheImageLookupOrg
field can be used to override the organization ID used when looking up AMIs for machines. Note that theImageLookupOrg
is only used when a machine does not specify an AMI ID.With this change, the
ImageLookupOrg
can be set at the cluster-level or at the machine-level. The machine-levelImageLookupOrg
takes precedence over the cluster-levelImageLookupOrg
.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1292