Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ AWSCluster: Allow setting ImageLookupOrg at the cluster level #1309

Merged

Conversation

alexbrand
Copy link
Contributor

What this PR does / why we need it:

This PR adds a new field, ImageLookupOrg, to the AWSClusterSpec struct. The ImageLookupOrg field can be used to override the organization ID used when looking up AMIs for machines. Note that the ImageLookupOrg is only used when a machine does not specify an AMI ID.

With this change, the ImageLookupOrg can be set at the cluster-level or at the machine-level. The machine-level ImageLookupOrg takes precedence over the cluster-level ImageLookupOrg.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1292

@k8s-ci-robot
Copy link
Contributor

Hi @alexbrand. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 31, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 31, 2019
Copy link
Member

@detiber detiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 31, 2019
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 31, 2019
@alexbrand
Copy link
Contributor Author

@detiber I noticed that the CRD yaml got restructured a bit in this PR. Is that expected?

@detiber
Copy link
Member

detiber commented Oct 31, 2019

@detiber I noticed that the CRD yaml got restructured a bit in this PR. Is that expected?

Yes, this is the first divergence that I'm aware of with v1alpha2 -> v1alpha3, so this is expected :)

@alexbrand
Copy link
Contributor Author

Got it! Thanks @detiber

@detiber
Copy link
Member

detiber commented Oct 31, 2019

/assign @ncdc

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2019
Signed-off-by: Alexander Brand <alexbrand09@gmail.com>
@detiber
Copy link
Member

detiber commented Oct 31, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexbrand, detiber

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2019
@k8s-ci-robot k8s-ci-robot merged commit f69282c into kubernetes-sigs:master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ImageLookupOrg to AWSClusterSpec
4 participants