Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃弮 Add v1alpha2 to v1alpha3 conversion webhooks #1329

Merged
merged 1 commit into from
Nov 7, 2019

Conversation

noamran
Copy link
Contributor

@noamran noamran commented Nov 6, 2019

What this PR does / why we need it:
Adds v1alpha2 to v1alpha3 conversion webhooks
Which issue(s) this PR fixes:
Fixes #1204

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 6, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @noamran. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 6, 2019
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 6, 2019
@ncdc
Copy link
Contributor

ncdc commented Nov 6, 2019

/cc
/assign
/ok-to-test
/milestone v0.3.0

@k8s-ci-robot
Copy link
Contributor

@ncdc: The provided milestone is not valid for this repository. Milestones in this repository: [Next, v0.4.x, v0.5.0]

Use /milestone clear to clear the milestone.

In response to this:

/cc
/assign
/ok-to-test
/milestone v0.3.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 6, 2019
@noamran noamran changed the title [WIP] Add v1alpha2 to v1alpha3 conversion webhooks Add v1alpha2 to v1alpha3 conversion webhooks Nov 7, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2019
@noamran noamran changed the title Add v1alpha2 to v1alpha3 conversion webhooks 馃弮: Add v1alpha2 to v1alpha3 conversion webhooks Nov 7, 2019
@noamran noamran changed the title 馃弮: Add v1alpha2 to v1alpha3 conversion webhooks 馃弮 Add v1alpha2 to v1alpha3 conversion webhooks Nov 7, 2019
@noamran
Copy link
Contributor Author

noamran commented Nov 7, 2019

/retest

@noamran noamran changed the title 馃弮 Add v1alpha2 to v1alpha3 conversion webhooks [WIP]馃弮 Add v1alpha2 to v1alpha3 conversion webhooks Nov 7, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2019
@k8s-ci-robot
Copy link
Contributor

@noamran: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-cluster-api-provider-aws-make-conformance 17413ece05a652da5459e2cf5c643baf37b3a303 link /test pull-cluster-api-provider-aws-make-conformance

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@noamran noamran changed the title [WIP]馃弮 Add v1alpha2 to v1alpha3 conversion webhooks 馃弮 Add v1alpha2 to v1alpha3 conversion webhooks Nov 7, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2019
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/assign @ncdc

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: noamran, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2019
@vincepri
Copy link
Member

vincepri commented Nov 7, 2019

/milestone v0.5.0

@k8s-ci-robot k8s-ci-robot added this to the v0.5.0 milestone Nov 7, 2019
@ncdc
Copy link
Contributor

ncdc commented Nov 7, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2f6834f into kubernetes-sigs:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add v1alpha2 to v1alpha3 conversion webhooks
4 participants