馃悰 Fix IMAGE_ID issue in examples #1337
Conversation
ncdc
added
kind/bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
k8s-ci-robot
added
the
size/M
|
@dims does this look ok to you? |
|
/hold grrr |
k8s-ci-robot
added
the
do-not-merge/hold
|
FWIW, I have seen this failure in other PRs as well |
|
The The most recent failure was the control plane never came up, but in theory the Machines and AWSMachines were all created. |
|
Found some things in the ec2 instance's journal. Not sure if these are relevant or red herrings:
|
|
Hmm, seeing that in master too, in https://storage.googleapis.com/kubernetes-jenkins/logs/ci-cluster-api-provider-aws-make-conformance-master/1192488049464840192/artifacts/logs/clusterapi-control-plane/journal.log Maybe we should merge this and work on fixing whatever is keeping the apiserver from running separately? |
|
/cc @dims |
k8s-ci-robot
added
the
lgtm
|
AHA! So maybe I need to do some more work. /lgtm cancel |
k8s-ci-robot
removed
the
lgtm
|
FWIW, this is not because of this PR. It's also happening in master: https://storage.googleapis.com/kubernetes-jenkins/logs/ci-cluster-api-provider-aws-make-conformance-master/1192488049464840192/artifacts/logs/clusterapi-control-plane/pods/capa-system_capa-controller-manager-84778d978f-6rm79_4ddf2dda-a935-49f2-bbb6-33040c413c94/manager/0.log |
Remove the ${IMAGE_ID} placeholder from the examples, as it's only used
for e2e conformance testing, and it's broken for example usage.
Use kustomize patches to handle the IMAGE_ID for e2e testing instead.
Signed-off-by: Andy Goldstein <goldsteina@vmware.com>
(cherry picked from commit 0681bee)
Signed-off-by: Andy Goldstein <goldsteina@vmware.com>
We can't have create-cluster-management have generate-examples as a prerequisite because our e2e conformance script calls generate-examples standalone (with variables), and then later calls create-cluster-management. If generate-examples is a prereq, when e2e conformance calls create-cluster-management, it will run generate-examples a 2nd time, but without the proper variables. Signed-off-by: Andy Goldstein <goldsteina@vmware.com>
|
/test pull-cluster-api-provider-aws-make-conformance |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
| .PHONY: create-cluster-management | ||
| create-cluster-management: $(CLUSTERCTL) generate-examples ## Create a development Kubernetes cluster on AWS in a KIND management cluster. | ||
| create-cluster-management: $(CLUSTERCTL) ## Create a development Kubernetes cluster on AWS in a KIND management cluster. | ||
| @if [[ ! -f examples/_out/cert-manager.yaml ]]; then echo "Examples are missing. Run 'make generate-examples' first."; exit 1; fi |
|
Working! |
k8s-ci-robot
removed
the
do-not-merge/hold
|
@ncdc: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What this PR does / why we need it:
Remove the ${IMAGE_ID} placeholder from the examples, as it's only used
for e2e conformance testing, and it's broken for example usage.
Use kustomize patches to handle the IMAGE_ID for e2e testing instead.
Cherry-pick of #1336 for
masterWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #