-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add support for extra AWS policies in clusterawsadm #1426
✨ Add support for extra AWS policies in clusterawsadm #1426
Conversation
Signed-off-by: John Harris <joharris@vmware.com>
Hi @johnharris85. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnharris85, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@johnharris85 this change broke our e2e code: https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/ci-cluster-api-provider-aws-e2e-master/1206646250376531968. Would you be able to fix it? I opened #1428 |
Yup will look in ~1hr when I get home.
…On Mon, Dec 16, 2019, 12:11 Andy Goldstein ***@***.***> wrote:
@johnharris85 <https://github.com/johnharris85> this change broke our e2e
code:
https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/ci-cluster-api-provider-aws-e2e-master/1206646250376531968.
Would you be able to fix it? I opened #1428
<#1428>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1426?email_source=notifications&email_token=AAFWF3KJ7I6E7CLCFYXU5ITQY7OH5A5CNFSM4J3M6O62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG76B7Q#issuecomment-566223102>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFWF3KTLUFRG2PFZK6GQ6DQY7OH5ANCNFSM4J3M6O6Q>
.
|
…onal-policies 🐛 Fix broken e2e test caused by #1426
What this PR does / why we need it:
Convenience feature to allow users to specify extra policies to the control plane and node roles that
clusterawsadm
creates.Which issue(s) this PR fixes:
Fixes #1390
Signed-off-by: John Harris joharris@vmware.com