-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Add version to user-agent for AWS API calls #1427
Conversation
For the reviewers -- note that because version information was needed for the controller (and not just I modeled the changes to the Many thanks to @randomvariable for the assistance on the version refactoring. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aaroniscode, detiber The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
/hold cancel |
What this PR does / why we need it:
The AWS SDK adds the SDK version to the user-agent of API calls. This adds the version of the Cluster API AWS provider to the user-agent string.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1242