Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Add version to user-agent for AWS API calls #1427

Merged
merged 1 commit into from
Dec 17, 2019
Merged

✨Add version to user-agent for AWS API calls #1427

merged 1 commit into from
Dec 17, 2019

Conversation

aaroniscode
Copy link
Contributor

What this PR does / why we need it:
The AWS SDK adds the SDK version to the user-agent of API calls. This adds the version of the Cluster API AWS provider to the user-agent string.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1242

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 16, 2019
@aaroniscode
Copy link
Contributor Author

aaroniscode commented Dec 16, 2019

For the reviewers -- note that because version information was needed for the controller (and not just clusterawsadm I refactored the version code to be a shared package for both to use.

I modeled the changes to the clusterawsadm version command to be very similar to how kubectl and kubeadm work.

Many thanks to @randomvariable for the assistance on the version refactoring.

@randomvariable
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2019
@detiber
Copy link
Member

detiber commented Dec 17, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aaroniscode, detiber

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2019
Dockerfile Show resolved Hide resolved
@detiber
Copy link
Member

detiber commented Dec 17, 2019

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2019
Makefile Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2019
@vincepri
Copy link
Member

/hold cancel
/lgtm

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2019
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit 994d1d1 into kubernetes-sigs:master Dec 17, 2019
@aaroniscode aaroniscode deleted the user_agent branch December 17, 2019 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set user-agent for calls to AWS
6 participants